Re: [PATCH v2] mac80211: Prevent unregistering of unregistered hw

[Ivo van Doorn <ivdoorn@gmail.com>]

On Friday 23 March 2007 21:14, Johannes Berg wrote:
> On Fri, 2007-03-23 at 20:21 +0100, Ivo van Doorn wrote:
> 
> > diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
> > index 577dbe3..e7a613d 100644
> > --- a/net/mac80211/ieee80211.c
> > +++ b/net/mac80211/ieee80211.c
> > @@ -4765,6 +4765,9 @@ void ieee80211_unregister_hw(struct ieee80211_hw *hw)
> >  	/* TODO: skb_queue should be empty here, no need to do anything? */
> >  
> >  	rtnl_lock();
> > +
> > +	BUG_ON(local->reg_state != IEEE80211_DEV_REGISTERED);
> > +
> 
> Hm. Maybe that's better since then there's no race like in my patch. Use
> this one instead of mine please. But it does kill the system pretty
> badly if you BUG_ON with rtnl held :)

Well it would increase motivation to fix such a bug in the driver then. ;)
(yes, fixing that bug in rt2x00 is on my todo list :P)

Ivo