From: David Miller <davem@davemloft.net>
To: acme@ghostprotocols.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 0/3]: Further reduction of direct access to skb->data
Date: Sat, 24 Mar 2007 20:20:18 -0700 (PDT) [thread overview]
Message-ID: <20070324.202018.41636403.davem@davemloft.net> (raw)
In-Reply-To: <20070324210706.GV17811@ghostprotocols.net>
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Date: Sat, 24 Mar 2007 18:07:06 -0300
> Hi David,
>
> Please take a look, at first I thought about adding a skb_copy_{from,to}_data,
> that would do just the memcpy, but then skb_{copy,store}_bits seems to be fit for this
> purpose, but its more costly in some cases, comments?
>
> Available at:
>
> master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22
>
I think you should make the named alias for direct memcpy()
instead, call it skb_copy_{from,to}_linear_data() so that the
assumed invariant is well documented.
prev parent reply other threads:[~2007-03-25 3:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-24 21:07 [PATCH 0/3]: Further reduction of direct access to skb->data Arnaldo Carvalho de Melo
2007-03-25 3:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070324.202018.41636403.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@ghostprotocols.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.