From: Srivatsa Vaddagiri <vatsa@in.ibm.com>
To: Paul Jackson <pj@sgi.com>
Cc: sekharan@us.ibm.com, ckrm-tech@lists.sourceforge.net,
linux-kernel@vger.kernel.org, xemul@sw.ru, dev@sw.ru,
rohitseth@google.com, ebiederm@xmission.com, mbligh@google.com,
winget@google.com, containers@lists.osdl.org, serue@us.ibm.com,
menage@google.com, devel@openvz.org
Subject: Re: [ckrm-tech] [PATCH 1/7] containers (V7): Generic container system abstracted from cpusets code
Date: Sun, 25 Mar 2007 10:35:07 +0530 [thread overview]
Message-ID: <20070325050507.GG11794@in.ibm.com> (raw)
In-Reply-To: <20070324214550.d6e654bf.pj@sgi.com>
On Sat, Mar 24, 2007 at 09:45:50PM -0700, Paul Jackson wrote:
> Nice work - thanks. Yes, both an extra cpuset count and a negative
> cpuset count are bad news, opening the door to the usual catastrophes.
>
> Would you like the honor of submitting the patch to add a task_lock
> to cpuset_exit()? If you do, be sure to fix, or at least remove,
> the cpuset_exit comment lines:
I will try to send out a patch later today to fix this bug in mainline
cpuset code. I happened to notice this race with my rcfs patch and observed
same is true with cpuset/container code also.
> * We don't need to task_lock() this reference to tsk->cpuset,
> * because tsk is already marked PF_EXITING, so attach_task() won't
> * mess with it, or task is a failed fork, never visible to attach_task.
Sure, I had seen that.
> So, in real life, this would be a difficult race to trigger.
Agreed, but good to keep code clean isn't it? :)
> Thanks for finding this.
Wellcome!
--
Regards,
vatsa
next prev parent reply other threads:[~2007-03-25 4:57 UTC|newest]
Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 8:15 [PATCH 0/7] containers (V7): Generic Process Containers menage
2007-02-12 8:15 ` [PATCH 1/7] containers (V7): Generic container system abstracted from cpusets code menage
2007-02-12 12:33 ` Srivatsa Vaddagiri
2007-02-12 19:26 ` Paul Menage
2007-02-12 19:46 ` Paul Menage
2007-02-13 5:48 ` Srivatsa Vaddagiri
2007-02-13 8:16 ` [ckrm-tech] " Srivatsa Vaddagiri
2007-03-07 12:21 ` Srivatsa Vaddagiri
2007-03-07 14:06 ` [ckrm-tech] " Srivatsa Vaddagiri
2007-03-07 20:50 ` Paul Menage
2007-03-08 10:38 ` [ckrm-tech] " Srivatsa Vaddagiri
2007-03-08 10:40 ` Paul Menage
2007-03-11 19:38 ` Paul Jackson
2007-03-12 14:19 ` Srivatsa Vaddagiri
2007-03-22 9:56 ` Srivatsa Vaddagiri
2007-03-22 10:20 ` Srivatsa Vaddagiri
2007-03-24 15:05 ` Srivatsa Vaddagiri
2007-03-24 19:25 ` Paul Jackson
2007-03-25 0:45 ` Srivatsa Vaddagiri
2007-03-25 1:41 ` Paul Jackson
2007-03-25 2:28 ` Srivatsa Vaddagiri
2007-03-25 4:16 ` Srivatsa Vaddagiri
2007-03-25 5:43 ` Paul Jackson
2007-03-25 8:21 ` Srivatsa Vaddagiri
2007-03-25 4:45 ` Paul Jackson
2007-03-25 5:05 ` Srivatsa Vaddagiri [this message]
2007-03-25 4:59 ` Paul Jackson
2007-02-12 8:15 ` [PATCH 2/7] containers (V7): Cpusets hooked into containers menage
2007-02-15 20:35 ` Serge E. Hallyn
2007-02-15 20:49 ` Paul Menage
2007-03-07 14:34 ` Srivatsa Vaddagiri
2007-03-07 16:01 ` Paul Menage
2007-03-07 16:31 ` [ckrm-tech] " Srivatsa Vaddagiri
2007-03-07 16:31 ` Paul Menage
2007-03-07 14:52 ` Srivatsa Vaddagiri
2007-03-07 16:12 ` Paul Menage
2007-02-12 8:15 ` [PATCH 4/7] containers (V7): Simple CPU accounting container subsystem menage
2007-02-12 8:15 ` [PATCH 5/7] containers (V7): Resource Groups over generic containers menage
2007-02-12 8:15 ` [PATCH 6/7] containers (V7): BeanCounters over generic process containers menage
2007-02-12 15:34 ` Srivatsa Vaddagiri
2007-02-12 18:49 ` Paul Menage
2007-02-13 8:52 ` Pavel Emelianov
2007-02-13 9:03 ` Paul Menage
2007-02-13 9:18 ` Pavel Emelianov
2007-02-13 9:37 ` Paul Menage
2007-02-13 9:49 ` Pavel Emelianov
2007-02-12 8:15 ` [PATCH 7/7] containers (V7): Container interface to nsproxy subsystem menage
2007-03-24 5:05 ` [ckrm-tech] " Srivatsa Vaddagiri
2007-03-24 16:23 ` Srivatsa Vaddagiri
2007-03-26 21:57 ` Serge E. Hallyn
2007-03-28 14:55 ` Srivatsa Vaddagiri
2007-03-28 15:26 ` Serge E. Hallyn
2007-03-26 21:55 ` Serge E. Hallyn
2007-03-31 2:47 ` Srivatsa Vaddagiri
2007-04-02 14:09 ` Serge E. Hallyn
2007-04-02 14:27 ` Srivatsa Vaddagiri
2007-04-02 18:02 ` Eric W. Biederman
2007-04-03 14:16 ` Srivatsa Vaddagiri
2007-04-03 15:32 ` Serge E. Hallyn
2007-04-03 15:45 ` Paul Menage
2007-04-03 15:54 ` Serge E. Hallyn
2007-04-03 16:16 ` Srivatsa Vaddagiri
2007-04-03 16:26 ` Kirill Korotaev
2007-04-03 16:46 ` Srivatsa Vaddagiri
2007-04-03 16:52 ` Paul Menage
2007-04-03 17:11 ` Srivatsa Vaddagiri
2007-04-03 17:10 ` Paul Menage
2007-04-03 17:30 ` Srivatsa Vaddagiri
2007-04-03 17:30 ` Paul Menage
2007-04-03 17:51 ` Srivatsa Vaddagiri
2007-04-03 17:49 ` Paul Menage
2007-04-04 3:07 ` Srivatsa Vaddagiri
2007-04-04 3:44 ` Paul Jackson
2007-04-04 4:04 ` Paul Menage
2007-04-04 5:15 ` Srivatsa Vaddagiri
2007-04-04 7:00 ` Paul Menage
2007-04-04 17:26 ` Srivatsa Vaddagiri
2007-04-04 17:42 ` Srivatsa Vaddagiri
2007-04-04 18:57 ` Paul Menage
2007-04-04 23:02 ` Eric W. Biederman
2007-04-05 1:35 ` Paul Menage
2007-04-05 1:37 ` Paul Menage
2007-04-05 16:57 ` Srivatsa Vaddagiri
2007-04-05 17:14 ` Srivatsa Vaddagiri
2007-04-06 21:54 ` Paul Menage
2007-04-05 2:57 ` Paul Menage
2007-04-05 6:39 ` Srivatsa Vaddagiri
2007-04-05 6:46 ` Srivatsa Vaddagiri
2007-04-05 6:48 ` Paul Menage
2007-04-05 8:49 ` Srivatsa Vaddagiri
2007-04-05 9:29 ` Paul Menage
2007-04-05 12:43 ` Srivatsa Vaddagiri
2007-04-05 14:13 ` Srivatsa Vaddagiri
2007-04-05 14:13 ` Paul Menage
2007-04-05 14:46 ` Srivatsa Vaddagiri
2007-04-03 17:34 ` Srivatsa Vaddagiri
2007-04-03 17:29 ` Paul Menage
2007-04-03 16:10 ` Srivatsa Vaddagiri
2007-04-03 15:41 ` Serge E. Hallyn
2007-02-12 9:18 ` [PATCH 0/7] containers (V7): Generic Process Containers Paul Jackson
2007-02-12 9:32 ` Paul Menage
2007-02-12 9:52 ` Paul Jackson
2007-02-12 22:38 ` Sam Vilain
2007-02-12 22:47 ` Serge E. Hallyn
2007-02-12 23:18 ` Paul Menage
2007-02-12 23:15 ` Paul Menage
2007-02-13 0:30 ` Sam Vilain
2007-02-13 0:42 ` [ckrm-tech] " Paul Menage
2007-02-13 1:13 ` Sam Vilain
2007-02-13 1:47 ` Paul Menage
2007-02-20 17:34 ` Eric W. Biederman
2007-02-20 17:55 ` Paul Menage
2007-02-20 19:29 ` Eric W. Biederman
2007-02-20 22:47 ` Paul Menage
2007-02-20 23:08 ` Sam Vilain
2007-02-20 23:36 ` Paul Menage
2007-02-20 23:32 ` Serge E. Hallyn
2007-02-20 21:58 ` Sam Vilain
2007-02-20 22:19 ` Paul Menage
2007-02-20 22:58 ` Sam Vilain
2007-02-20 23:28 ` Paul Menage
2007-02-20 23:37 ` Serge E. Hallyn
[not found] ` <20070212085104.485337000@menage.corp.google.com>
2007-02-12 15:27 ` [PATCH 3/7] containers (V7): Add generic multi-subsystem API to containers Srivatsa Vaddagiri
2007-02-12 18:40 ` Paul Menage
2007-02-13 13:19 ` Srivatsa Vaddagiri
2007-02-15 1:17 ` Paul Menage
2007-02-12 15:39 ` Serge E. Hallyn
2007-02-12 15:56 ` Cedric Le Goater
2007-02-12 18:31 ` Paul Menage
2007-02-14 8:49 ` Balbir Singh
2007-03-08 17:52 ` Srivatsa Vaddagiri
2007-03-24 12:51 ` [ckrm-tech] " Srivatsa Vaddagiri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070325050507.GG11794@in.ibm.com \
--to=vatsa@in.ibm.com \
--cc=ckrm-tech@lists.sourceforge.net \
--cc=containers@lists.osdl.org \
--cc=dev@sw.ru \
--cc=devel@openvz.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@google.com \
--cc=menage@google.com \
--cc=pj@sgi.com \
--cc=rohitseth@google.com \
--cc=sekharan@us.ibm.com \
--cc=serue@us.ibm.com \
--cc=winget@google.com \
--cc=xemul@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.