All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: "Kevin P. Fleming" <lkml@kpfleming.us>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Greg KH <greg@kroah.com>,
	Jan Beulich <jbeulich@novell.com>, Alan Cox <alan@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: drivers/pci/probe.c patch in 2.6.20.4 causes 'cannot adjust BAR0 (not I/O)' on NVidia MCP51
Date: Mon, 26 Mar 2007 05:08:03 +0200	[thread overview]
Message-ID: <20070326030803.GT16477@stusta.de> (raw)
In-Reply-To: <46072F2A.9060803@kpfleming.us>

On Sun, Mar 25, 2007 at 07:25:46PM -0700, Kevin P. Fleming wrote:
> Adrian Bunk wrote:
> > It also adds PCI_BASE_ADDRESS_SPACE_IO to the flags which it didn't 
> > without the patch.
> 
> As an experiment I modified 2.6.20.4 to _only_ remove that value from
> the combined value for the flags and it did not help in any noticeable
> way. I can reliably boot and operate the machine with the original patch
> reversed, though.

OK thanks, then it's something else.

I see only one more thing that might make any difference:
Perhaps we are not seeing the problematic operation due to the different 
loglevel?

Please change in the third printk() the patch adds the KERN_INFO to 
KERN_WARNING.

If you get a "...trying to change BAR..." before it hangs, remove the 
pci_write_config_dword() line - this should then fix it.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2007-03-26  3:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-25 15:23 drivers/pci/probe.c patch in 2.6.20.4 causes 'cannot adjust BAR0 (not I/O)' on NVidia MCP51 Kevin P. Fleming
2007-03-25 16:11 ` Greg KH
2007-03-25 17:22   ` Kevin P. Fleming
2007-03-25 20:08   ` Alan Cox
2007-03-25 19:21     ` Adrian Bunk
2007-03-26  2:25       ` Kevin P. Fleming
2007-03-26  3:08         ` Adrian Bunk [this message]
2007-03-26  6:58   ` Jan Beulich
2007-03-26 10:55     ` Alan Cox
2007-03-25 16:43 ` Gabriel C
2007-03-25 18:13   ` Torsten Kaiser
2007-03-25 19:09     ` Grzegorz Chwesewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070326030803.GT16477@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=alan@redhat.com \
    --cc=bzolnier@gmail.com \
    --cc=greg@kroah.com \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@kpfleming.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.