All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Eygene Ryabinkin <rea-git@codelabs.ru>, git@vger.kernel.org
Subject: Re: [PATCH] pager: default to LESS=FRX not LESS=FRSX
Date: Mon, 26 Mar 2007 04:36:17 -0400	[thread overview]
Message-ID: <20070326083617.GG13247@spearce.org> (raw)
In-Reply-To: <7vwt14xvaw.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:
> Eygene Ryabinkin <rea-git@codelabs.ru> writes:
> 
> > Remove unnecessary '-S' option that enabled less to chop long lines.
> > It used to provide some confusion at least for the 'git diff':
> > "Where are my long lines? Are they missed from the patch?".
> 
> It is not "unnecessary", but only "what _you_ are not used to".
> As this breaks expectentions of people already familiar with
> what git does by default, I cannot take this patch.

Hear hear.  I completely agree with Junio.  I (and a number of
other users that I work with) expect this behevaior by default.

-- 
Shawn.

  reply	other threads:[~2007-03-26  8:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-26  7:35 [PATCH] pager: default to LESS=FRX not LESS=FRSX Eygene Ryabinkin
2007-03-26  8:28 ` Junio C Hamano
2007-03-26  8:36   ` Shawn O. Pearce [this message]
2007-03-26  8:44     ` Junio C Hamano
2007-03-26 10:08       ` Eygene Ryabinkin
2007-03-26 18:45         ` Junio C Hamano
2007-03-26 19:03         ` Jeff King
2007-03-27  6:47           ` Eygene Ryabinkin
2007-03-26 19:14       ` Bill Lear
2007-03-26 20:27         ` Junio C Hamano
2007-03-27  6:54         ` Eygene Ryabinkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070326083617.GG13247@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=rea-git@codelabs.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.