From: Paul Mundt <lethal@linux-sh.org>
To: "Wu, Bryan" <bryan.wu@analog.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] Blackfin arch: cleanup cache header file
Date: Mon, 26 Mar 2007 20:28:18 +0900 [thread overview]
Message-ID: <20070326112818.GA18673@linux-sh.org> (raw)
In-Reply-To: <1174903902.32691.64.camel@roc-desktop>
On Mon, Mar 26, 2007 at 06:11:42PM +0800, Wu, Bryan wrote:
> +#define L1_CACHE_SHIFT 5
> +#define L1_CACHE_BYTES (1 << L1_CACHE_SHIFT)
>
> -/* For speed we do need to align these ...MaTed---*/
> -/* But include/linux/cache.h does this for us if we DO not define ...MaTed---*/
> -#define __cacheline_aligned /***** maybe no need this Tony *****/
> +/*
> + * Don't make __cacheline_aligned and
> + * ____cacheline_aligned defined in include/linux/cache.h
> + */
> +#define __cacheline_aligned
> #define ____cacheline_aligned
>
You still don't need this. Ancient versions of gcc had problems with the
attribute, but it's not even possible to build the kernel with those
anymore. Please remove these and try again. You can simply alias
SMP_CACHE_BYTES to L1_CACHE_BYTES if you've left this in due to the
resulting build failure.
m68knommu seems to be another user that never got cleaned up, perhaps
it's a good time to kill that off too..
prev parent reply other threads:[~2007-03-26 11:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-26 10:11 [PATCH -mm] Blackfin arch: cleanup cache header file Wu, Bryan
2007-03-26 11:28 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070326112818.GA18673@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bryan.wu@analog.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.