All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH] lm-sensors: add dme1737 support
Date: Mon, 26 Mar 2007 11:39:47 +0000	[thread overview]
Message-ID: <20070326133947.bc9121bf.khali@linux-fr.org> (raw)
In-Reply-To: <191fb4ca0703232147q3a74701ci4bedf256201ee587@mail.gmail.com>

Hi Juerg,

On Sun, 25 Mar 2007 11:43:39 -0700, Juerg Haefliger wrote:
> > >       { "pwm2", "pwm2", 0, "fan2_pwm" },
> > >       { "pwm3", "pwm3", 0, "fan3_pwm" },
> > >       { "pwm4", "pwm4", 0, "fan4_pwm" },
> > > +     { "pwm5", "pwm5", 0, "fan5_pwm" },
> > > +     { "pwm6", "pwm6", 0, "fan6_pwm" },
> > >       { "pwm1_enable", "pwm1_enable", 0, "fan1_pwm_enable" },
> > >       { "pwm2_enable", "pwm2_enable", 0, "fan2_pwm_enable" },
> > >       { "pwm3_enable", "pwm3_enable", 0, "fan3_pwm_enable" },
> > >       { "pwm4_enable", "pwm4_enable", 0, "fan4_pwm_enable" },
> > > +     { "pwm5_enable", "pwm5_enable", 0, "fan5_pwm_enable" },
> > > +     { "pwm6_enable", "pwm6_enable", 0, "fan6_pwm_enable" },
> > >       { NULL, NULL }
> > >  };
> > >
> >
> > You shouldn't need this, the alternative names were only in use for a
> > short range of early 2.6 kernels, and your driver will never be
> > backported to these kernels.
> 
> If I don't have these lines I get 'Can't get pmw5 data' and 'Can't get
> pwm6 data' errors. Isn't this the right fix?

Ah, you're right, there was a bug in libsensors in the way the pwm
symbol names were translated. I fixed it diffrently in SVN, so that it
will work for pwm7, pwm8 etc. too:
http://www.lm-sensors.org/changeset?new=lm-sensors%2Ftrunk%2Flib%2Fproc.c%404354&old=lm-sensors%2Ftrunk%2Flib%2Fproc.c%404287
Please confirm it works for you.

Thanks,
-- 
Jean Delvare


  parent reply	other threads:[~2007-03-26 11:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-24  4:47 [lm-sensors] [PATCH] lm-sensors: add dme1737 support Juerg Haefliger
2007-03-25 16:38 ` Jean Delvare
2007-03-25 18:43 ` Juerg Haefliger
2007-03-26 11:39 ` Jean Delvare [this message]
2007-03-26 23:20 ` Juerg Haefliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070326133947.bc9121bf.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.