From: Andrew Morton <akpm@linux-foundation.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] add file position info to proc
Date: Mon, 26 Mar 2007 23:35:58 -0800 [thread overview]
Message-ID: <20070326233558.9254cdfc.akpm@linux-foundation.org> (raw)
In-Reply-To: <E1HW5nH-0003P1-00@dorka.pomaz.szeredi.hu>
On Tue, 27 Mar 2007 09:08:35 +0200 Miklos Szeredi <miklos@szeredi.hu> wrote:
> > > This patch adds support for finding out the current file position,
> > > open flags and possibly other info in the future.
> >
> > fs/proc/base.c: In function 'proc_lookupfdinfo':
> > fs/proc/base.c:1584: warning: passing argument 3 of 'proc_lookupfd_common' from incompatible pointer type
> > fs/proc/base.c: In function 'proc_readfdinfo':
> > fs/proc/base.c:1590: warning: passing argument 4 of 'proc_readfd_common' from incompatible pointer type
> >
> > If taken, that callback into proc_lookupfd_common() will crash the kernel.
>
> Ugh. Some constification in -mm that I hadn't noticed. Resending.
>
OK, I misread the code. I fixed it up.
next prev parent reply other threads:[~2007-03-27 7:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-24 22:04 [patch] add file position info to proc Miklos Szeredi
2007-03-25 23:45 ` Andrew Morton
2007-03-26 0:05 ` Neil Brown
2007-03-26 9:41 ` Folkert van Heusden
2007-03-27 21:55 ` Dave Hansen
2007-03-27 0:45 ` Andrew Morton
2007-03-27 7:08 ` Miklos Szeredi
2007-03-27 7:35 ` Andrew Morton [this message]
2007-03-27 21:24 ` Pavel Machek
2007-03-27 21:33 ` Jörn Engel
2007-03-27 21:36 ` Andrew Morton
2007-03-27 21:43 ` Miklos Szeredi
2007-03-27 22:33 ` Pavel Machek
2007-03-27 23:05 ` Miklos Szeredi
-- strict thread matches above, loose matches on Subject: below --
2007-03-09 13:54 [PATCH] " Miklos Szeredi
2007-03-09 15:15 ` Dave Kleikamp
2007-03-09 15:23 ` Benjamin LaHaise
2007-03-09 15:37 ` Dave Kleikamp
2007-03-09 16:00 ` Miklos Szeredi
2007-03-09 17:45 ` Jan Engelhardt
2007-03-09 21:03 ` Miklos Szeredi
2007-03-09 21:26 ` Dave Kleikamp
2007-03-09 15:18 ` Jörn Engel
2007-03-09 15:52 ` Miklos Szeredi
2007-03-09 15:54 ` Miklos Szeredi
2007-03-10 7:05 ` Chris Wedgwood
2007-03-10 14:02 ` Jan Engelhardt
2007-03-10 21:19 ` Chris Wedgwood
2007-03-10 21:33 ` Jan Engelhardt
2007-03-10 21:40 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070326233558.9254cdfc.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.