All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Deegan <Tim.Deegan@xensource.com>
To: aditya shevalkar <aditya27783@yahoo.co.in>
Cc: xen-devel@lists.xensource.com
Subject: Re: Question on shadow_invlpg return value handling.
Date: Tue, 27 Mar 2007 08:32:25 +0000	[thread overview]
Message-ID: <20070327083225.GA11216@york.uk.xensource.com> (raw)
In-Reply-To: <604922.39574.qm@web8705.mail.in.yahoo.com>

At 10:21 +0530 on 27 Mar (1174990916), aditya shevalkar wrote:
> Can anyone explain me where does this return values from sh_invlpg are used.
>  The comment is given below:
> /* Called when the guest requests an invlpg.  Returns 1 if the invlpg
> * instruction should be issued on the hardware, or 0 if it's safe not
>  * to do so. */
> I have followed the following path of function call in my study of the function.
> vmx_vmexit_do_invlpg(va) à  shadow_invlpg(v, va) à sh_invlpg(struct vcpu *v, unsigned long va).

The VMX (and SVM) code ignores the return code of shadow_invlpg at the
moment, because they both flush the entire TLB on every VM entry anyway
(AMD's hardware support for tagged TLBs is apparently not quite useable
yet).

arch/x86/mm.c, which handles PV guests, uses the return code correctly,
e.g.:

  case MMUEXT_INVLPG_LOCAL:
       if ( !shadow_mode_enabled(d) 
            || shadow_invlpg(v, op.arg1.linear_addr) != 0 )
           local_flush_tlb_one(op.arg1.linear_addr);
       break;

Cheers,

Tim.

-- 
Tim Deegan <Tim.Deegan@xensource.com>, XenSource UK Limited
Registered office c/o EC2Y 5EB, UK; company number 05334508

  reply	other threads:[~2007-03-27  8:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-27  4:51 Question on shadow_invlpg return value handling aditya shevalkar
2007-03-27  8:32 ` Tim Deegan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-03-27 10:19 jeet
2007-03-27 10:29 ` Tim Deegan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070327083225.GA11216@york.uk.xensource.com \
    --to=tim.deegan@xensource.com \
    --cc=aditya27783@yahoo.co.in \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.