All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: "Brown, Len" <len.brown@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
	linux-acpi@vger.kernel.org
Subject: Re: Fw: Re: 2.6.21-rc4-mm1 + 4 hotfixes -- BUG: unable to handle kernel paging request at virtual address 6b6b6ceb -- EIP is at module_put+0x7/0x1f
Date: Tue, 27 Mar 2007 21:19:58 -0700	[thread overview]
Message-ID: <20070328041958.GA7669@kroah.com> (raw)
In-Reply-To: <1175053953.10369.2.camel@sli10-conroe.sh.intel.com>

On Wed, Mar 28, 2007 at 11:52:33AM +0800, Shaohua Li wrote:
> +static void cpuidle_state_sysfs_release(struct kobject *kobj)
> +{
> +	/* Nothing required to do here, just workaround kobject warning*/
> +}

NO!!!

Do people think that I add warnings to the kernel so that people can
just work around them by passing empty functions to the driver core?

Sometimes I wonder why I even try...

Please fix this code, it is wrong.

greg k-h

  reply	other threads:[~2007-03-28  4:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-22 17:52 Fw: Re: 2.6.21-rc4-mm1 + 4 hotfixes -- BUG: unable to handle kernel paging request at virtual address 6b6b6ceb -- EIP is at module_put+0x7/0x1f Andrew Morton
2007-03-23  2:04 ` Shaohua Li
2007-03-23  5:16   ` Greg KH
2007-03-28  3:52     ` Shaohua Li
2007-03-28  4:19       ` Greg KH [this message]
2007-03-28  4:27         ` Andrew Morton
2007-03-28  4:51           ` Greg KH
2007-03-28  5:09             ` Andrew Morton
2007-03-28  5:15               ` Greg KH
2007-03-28  5:13             ` Shaohua Li
2007-03-28  5:27               ` Greg KH
2007-03-28  5:39                 ` Shaohua Li
2007-03-28  5:58                   ` Greg KH
2007-03-28  6:49                     ` Shaohua Li
2007-03-29  8:16                       ` Shaohua Li
2007-03-30  5:18                       ` Greg KH
2007-03-30  6:33                         ` Shaohua Li
2007-03-30  7:05                           ` Greg KH
2007-03-30  7:08                             ` Shaohua Li
2007-03-30  7:51                               ` Greg KH
2007-03-30  7:55                                 ` Shaohua Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070328041958.GA7669@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.