Re: [patch 3/4] cpuidle: unsigned bitfield

[Len Brown <lenb@kernel.org>]

applied

thanks,
-len

On Tuesday 27 March 2007 01:38, akpm@linux-foundation.org wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> A 1-bit bitfield has no room for a sign bit.
> drivers/cpuidle/governors/ladder.c:54:16: error: dubious bitfield without explicit `signed' or `unsigned'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/cpuidle/governors/ladder.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/cpuidle/governors/ladder.c~cpuidle-unsigned-bitfield drivers/cpuidle/governors/ladder.c
> --- a/drivers/cpuidle/governors/ladder.c~cpuidle-unsigned-bitfield
> +++ a/drivers/cpuidle/governors/ladder.c
> @@ -51,7 +51,7 @@ struct ladder_device_state {
>  
>  struct ladder_device {
>  	struct ladder_device_state states[CPUIDLE_STATE_MAX];
> -	int bm_check:1;
> +	unsigned int bm_check:1;
>  	unsigned long bm_check_timestamp;
>  	unsigned long bm_activity; /* FIXME: bm activity should be global */
>  	int last_state_idx;
> _
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>