From: Paul Mundt <lethal@linux-sh.org>
To: "Wu, Bryan" <bryan.wu@analog.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blackfin arch fix stamp537 ISP1716 IRQ setting bug
Date: Thu, 29 Mar 2007 21:45:35 +0900 [thread overview]
Message-ID: <20070329124535.GA20019@linux-sh.org> (raw)
In-Reply-To: <1175165252.15391.40.camel@roc-desktop>
On Thu, Mar 29, 2007 at 06:47:32PM +0800, Wu, Bryan wrote:
> diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
> index 0f90ff9..a4219df 100644
> --- a/arch/blackfin/mach-bf537/boards/stamp.c
> +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> @@ -68,7 +68,7 @@ static struct resource bfin_isp1761_resources[] = {
> [1] = {
> .start = ISP1761_IRQ,
> .end = ISP1761_IRQ,
> - .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_LOWLEVEL,
> + .flags = IORESOURCE_IRQ,
> },
> };
>
So you've left the logic for set_irq_type(), yes? In that case, this
looks fine.
I'd add an Acked-by, but it probably doesn't matter :-)
prev parent reply other threads:[~2007-03-29 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-29 10:40 [PATCH] blackfin arch fix stamp537 ISP1716 IRQ setting bug Wu, Bryan
2007-03-29 10:47 ` Wu, Bryan
2007-03-29 12:45 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070329124535.GA20019@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.