From: Tony Lindgren <tony@atomide.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH 1/4] FB: sync with N800 tree (support for dynamic SRAM allocations)
Date: Thu, 29 Mar 2007 16:30:19 -0400 [thread overview]
Message-ID: <20070329203017.GO3638@atomide.com> (raw)
In-Reply-To: <200703281638.14657.david-b@pacbell.net>
* David Brownell <david-b@pacbell.net> [070328 19:39]:
> On Monday 05 March 2007 4:07 am, Imre Deak wrote:
> > - in addition to fixed FB regions - as passed by the bootloader -
> > allow dynamic allocations
> > - do some more checking against overlapping / reserved regions
> > - move the FB specific parts out from sram.c to fb.c
> >
> > Signed-off-by: Imre Deak <imre.deak@solidboot.com>
> > ---
> > arch/arm/mach-omap1/io.c | 4 +-
> > arch/arm/mach-omap2/io.c | 3 +-
> > arch/arm/plat-omap/fb.c | 271 ++++++++++++++++++++++++++++++++----
> > arch/arm/plat-omap/sram.c | 60 ++-------
> > include/asm-arm/arch-omap/omapfb.h | 5 +
> > include/asm-arm/arch-omap/sram.h | 3 -
> > 6 files changed, 261 insertions(+), 85 deletions(-)
>
> OK, I verified: reverting this lets my H4 board boot.
> Alternatively, the fix is to get rid of a GCC warning,
> so that stack garbage doesn't get used ...
>
> ========= CUT HERE
> Fix GCC-reported compile time bug which prevents booting
> when the framebuffer code is disabled.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>
> --- a/arch/arm/plat-omap/fb.c
> +++ b/arch/arm/plat-omap/fb.c
> @@ -327,7 +327,10 @@ unsigned long omapfb_reserve_sram(unsign
> unsigned long sram_vstart,
> unsigned long sram_size,
> unsigned long start_avail,
> - unsigned long size_avail) {}
> + unsigned long size_avail)
> +{
> + return 0;
> +}
>
>
> #endif
Pushing today.
Tony
prev parent reply other threads:[~2007-03-29 20:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-05 12:07 [PATCH 1/4] FB: sync with N800 tree (support for dynamic SRAM allocations) Imre Deak
2007-03-06 12:01 ` tony
2007-03-28 23:38 ` David Brownell
2007-03-29 20:30 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070329203017.GO3638@atomide.com \
--to=tony@atomide.com \
--cc=david-b@pacbell.net \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.