All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] bsg: minor bug fixes
Date: Fri, 30 Mar 2007 08:38:04 +0200	[thread overview]
Message-ID: <20070330063804.GE6320@kernel.dk> (raw)
In-Reply-To: <20070330103902U.fujita.tomonori@lab.ntt.co.jp>

On Fri, Mar 30 2007, FUJITA Tomonori wrote:
> This fixes the following minor issues:
> 
> - When bsg_register_queue is called with a request queue that doesn't
> have request_fn, it returns -EINVAL instead of zero.

Seems a little backwards, you wont be able to talk to the device then.
So, what is the purpose of this patch?

> - add EXPORT_SYMBOL_GPL for bsg_register_queue and
> bsg_unregister_queue.

ok

> - shut up gcc warnings

ok


-- 
Jens Axboe


  reply	other threads:[~2007-03-30  6:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-30  1:39 [PATCH] bsg: minor bug fixes FUJITA Tomonori
2007-03-30  6:38 ` Jens Axboe [this message]
2007-03-30  8:36   ` FUJITA Tomonori
2007-03-30  9:18     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070330063804.GE6320@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.