From: Jeff Dike <jdike@addtoit.com>
To: Jan Beulich <jbeulich@novell.com>
Cc: Sam Ravnborg <sam@ravnborg.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix dependency generation
Date: Fri, 30 Mar 2007 13:14:58 -0400 [thread overview]
Message-ID: <20070330171458.GA7573@c2.user-mode-linux.org> (raw)
In-Reply-To: <460D4C35.76E4.0078.0@novell.com>
On Fri, Mar 30, 2007 at 04:43:17PM +0100, Jan Beulich wrote:
> >But that will break UM - no??
> >See following note from fixdep:
> > * Note 2: if somebody writes HELLO_CONFIG_BOOM in a file, it will depend onto
> > * CONFIG_BOOM. This could seem a bug (not too hard to fix), but please do not
> > * fix it! Some UserModeLinux files (look at arch/um/) call CONFIG_BOOM as
> > * UML_CONFIG_BOOM, to avoid conflicts with /usr/include/linux/autoconf.h,
> > * through arch/um/include/uml-config.h; this fixdep "bug" makes sure that
> > * those files will have correct dependencies.
>
> Hmm, didn't see this note. Then this might warrant special casing UML, but
> penalizing all code due to this seems at least odd to me.
If I understand this, I would think that special-casing UML_CONFIG_*
instead of *_CONFIG_* would be the way to go.
Jeff
--
Work email - jdike at linux dot intel dot com
next prev parent reply other threads:[~2007-03-30 17:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-29 9:27 [PATCH] fix dependency generation Jan Beulich
2007-03-29 15:39 ` Randy Dunlap
2007-03-29 16:06 ` Jan Beulich
2007-03-29 16:38 ` Randy Dunlap
2007-03-30 9:14 ` Jan Beulich
2007-03-30 15:17 ` Randy Dunlap
2007-03-30 15:08 ` Sam Ravnborg
2007-03-30 15:43 ` Jan Beulich
2007-03-30 17:14 ` Jeff Dike [this message]
2007-03-31 6:42 ` Sam Ravnborg
2007-03-31 7:39 ` [PATCH 1/2] kconfig: factor out code in conf_spilt_config Sam Ravnborg
2007-03-31 7:40 ` [PATCH 2/2] kconfig/kbuild: fix dependency problem Sam Ravnborg
2007-03-31 16:11 ` [PATCH] fix dependency generation Roman Zippel
2007-04-01 18:45 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070330171458.GA7573@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.