From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@mvista.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH 2/2] ARM: OMAP: Fix PRCM base register usage for 243x
Date: Fri, 30 Mar 2007 14:58:18 -0400 [thread overview]
Message-ID: <20070330185816.GE18375@atomide.com> (raw)
In-Reply-To: <20070321000827.284905000@mvista.com>
* Kevin Hilman <khilman@mvista.com> [070320 20:09]:
> The PRCM base register is different on 242x and 243x. Use
> the #ifdef'd #define from omap24xx.h instead of the locally
> defined one.
>
> Signed-off-by: Kevin Hilman <khilman@mvista.com>
>
> ---
> arch/arm/mach-omap2/pm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: dev/arch/arm/mach-omap2/pm.c
> ===================================================================
> --- dev.orig/arch/arm/mach-omap2/pm.c
> +++ dev/arch/arm/mach-omap2/pm.c
> @@ -51,7 +51,6 @@
> #include <asm/arch/dma.h>
> #include <asm/arch/board.h>
>
> -#define PRCM_BASE 0x48008000
> #define PRCM_REVISION 0x000
> #define PRCM_SYSCONFIG 0x010
> #define PRCM_IRQSTATUS_MPU 0x018
> @@ -150,7 +149,7 @@ static void (*omap2_sram_idle)(void);
> static void (*omap2_sram_suspend)(int dllctrl);
> static void (*saved_idle)(void);
>
> -static u32 prcm_base = IO_ADDRESS(PRCM_BASE);
> +static u32 prcm_base = IO_ADDRESS(OMAP24XX_PRCM_BASE);
>
> static inline void prcm_write_reg(int idx, u32 val)
> {
>
Pushing today.
Tony
prev parent reply other threads:[~2007-03-30 18:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 0:07 [PATCH 0/2] 2430SDP fixes Kevin Hilman
2007-03-21 0:07 ` [PATCH 1/2] ARM: OMAP: Kconfig: replace ARCH_OMAP243X with ARCH_OMAP2430 Kevin Hilman
2007-03-30 18:57 ` Tony Lindgren
2007-03-21 0:07 ` [PATCH 2/2] ARM: OMAP: Fix PRCM base register usage for 243x Kevin Hilman
2007-03-30 18:58 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070330185816.GE18375@atomide.com \
--to=tony@atomide.com \
--cc=khilman@mvista.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.