From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] my first janitorial
Date: Sat, 31 Mar 2007 14:32:22 +0000 [thread overview]
Message-ID: <20070331143222.GA11845@kroah.com> (raw)
In-Reply-To: <9c9aa5d00703310639q68fa5d19k4d8e3bfb56b1fa6@mail.gmail.com>
On Sat, Mar 31, 2007 at 06:39:01AM -0700, Pedram M wrote:
> for: drivers/char/istallion.c
>
>
> @@ -4590,7 +4590,7 @@
> printk("stli_findpcibrds()\n");
> #endif
>
> - while ((dev = pci_find_device(PCI_VENDOR_ID_STALLION,
> + while ((dev = pci_get_device(PCI_VENDOR_ID_STALLION,
I think this leaks the reference count on the pci device. Where do you
decrement it?
Please read the documentation for the pci_get_device() function, it is
not a simple search-and-replace fix for this task.
thanks,
greg k-h
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2007-03-31 14:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-31 13:39 [KJ] my first janitorial Pedram M
2007-03-31 13:55 ` Arnaldo Carvalho de Melo
2007-03-31 13:59 ` Cong WANG
2007-03-31 14:32 ` Greg KH [this message]
2007-04-01 5:24 ` Pedram M
2007-04-01 5:24 ` Pedram M
2007-04-01 6:16 ` [KJ] " Jaco Kroon
2007-04-01 6:16 ` Jaco Kroon
2007-04-01 6:17 ` Willy Tarreau
2007-04-01 6:17 ` Willy Tarreau
2007-04-01 19:04 ` [KJ] " Jan Engelhardt
2007-04-01 19:04 ` Jan Engelhardt
2007-04-01 15:14 ` [KJ] " Alan Cox
2007-04-01 16:00 ` Alan Cox
2007-04-01 18:28 ` [KJ] " Jiri Slaby
2007-04-01 18:28 ` Jiri Slaby
2007-04-02 3:39 ` [KJ] " surya.prabhakar
2007-04-02 3:40 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070331143222.GA11845@kroah.com \
--to=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.