From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HYPC2-0000oo-0m
	for qemu-devel@nongnu.org; Mon, 02 Apr 2007 12:15:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HYPBz-0000ob-Lm
	for qemu-devel@nongnu.org; Mon, 02 Apr 2007 12:15:40 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HYPBz-0000oY-G9
	for qemu-devel@nongnu.org; Mon, 02 Apr 2007 12:15:39 -0400
Received: from phoenix.bawue.net ([193.7.176.60] helo=mail.bawue.net)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1HYP8v-0003hP-RK
	for qemu-devel@nongnu.org; Mon, 02 Apr 2007 12:12:30 -0400
Date: Mon, 2 Apr 2007 17:08:39 +0100
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD
Message-ID: <20070402160839.GJ24846@networkno.de>
References: <200704021025.l32APPUX024888@imap.tools.intra>
	<20070402124122.GE24846@networkno.de>
	<20070402.085851.796899796.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070402.085851.796899796.imp@bsdimp.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "M. Warner Losh" <imp@bsdimp.com>
Cc: qemu-devel@nongnu.org

M. Warner Losh wrote:
> In message: <20070402124122.GE24846@networkno.de>
>             Thiemo Seufer <ths@networkno.de> writes:
> : I made that "#ifdef _BSD" based on the assumption it is ok for all
> : BSD variants, including Darwin.
> 
> _BSD isn't defined on all variants of BSD.  sys/param.h defines BSD to
> be 199506 on all BSD systems (at least all of them derived from 4.4BSD
> lite).  sys/param.h also defines BSD4_3 and BSD4_4.  FreeBSD defines
> __FreeBSD__ in the compiler, NetBSD defined __NetBSD__, OpenBSD
> defines __OpenBSD__.  I'm unsure what darwin/osx define.
> 
> so unless I missed a change elsewhere in the build system to define
> _BSD, this change needs some more thought.

It is already used in other files. The define in qemu comes from the
configure script via config.h, which might be a bug.


Thiemo