Re: TSC2101/2102

[Imre Deak <imre.deak@solidboot.com>]

Hi,

On Tue, Apr 03, 2007 at 07:22:57AM -0400, Eduardo Valentin wrote:
> Hello again Imre,
> 
> 
>   I didn't understand properly your question. My bad. Sorry.
>   I used set_drvdata because it is used into lcd_h2.c (accordingly to
> my previous patch):
> @@ -117,6 +97,19 @@ struct lcd_panel h2_panel = {
> 
> static int h2_panel_probe(struct platform_device *pdev)
> {
> +	struct spi_device *tsc2101;
> +
> +	tsc2101 = dev_get_drvdata(&pdev->dev);
> +	if (tsc2101 == NULL) {
> +		dev_err(&pdev->dev, "no platform data\n");
> +		return -ENODEV;
> +	}
> 
>   Of course, it is clear enough that this dev_err message is wrong.
> It must be "no driver data". My bad again. However, why do you suggest
> use platform_data instead of driver_data?

That's the standard way platforms pass init data to the driver. The
driver can then use the driver_data field for it's own purpose.

But more important would be to know why platform_data gets zero'd, since
the device core is not touching it. A workaround you're proposing might
just delay some other problem..

--Imre