From: Matt Mackall <mpm@selenic.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Reorganizing structs to save space
Date: Tue, 3 Apr 2007 16:30:29 -0500 [thread overview]
Message-ID: <20070403213028.GV10459@waste.org> (raw)
In-Reply-To: <20070403122848.GA14224@ghostprotocols.net>
On Tue, Apr 03, 2007 at 09:28:48AM -0300, Arnaldo Carvalho de Melo wrote:
> module 16960 16848 112
That's huge.
> struct module_ref ref[255]; /* 480 16320 */
Huh. That's this:
struct module_ref
{
local_t count;
} ____cacheline_aligned;
This is horrible. Surely there's some way to do better than a
cacheline per module per possible CPU. We should only need 4 bytes per
module per online CPU.
And really, about the only case where we actually care about cacheline
bouncing here at all is on modules that do this per-packet. Just about
everyone else can get by with 4 bytes per module total.
--
Mathematics is the supreme nostalgia of our time.
prev parent reply other threads:[~2007-04-03 21:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-03 12:28 [RFC] Reorganizing structs to save space Arnaldo Carvalho de Melo
2007-04-03 21:30 ` Matt Mackall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070403213028.GV10459@waste.org \
--to=mpm@selenic.com \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.