From: Dmitry Torokhov <dtor@insightbb.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Pete Zaitcev <zaitcev@redhat.com>,
linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, stuart_hayes@dell.com
Subject: Re: usb hid: reset NumLock
Date: Wed, 4 Apr 2007 23:24:55 -0400 [thread overview]
Message-ID: <200704042324.56345.dtor@insightbb.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0704031046320.3808@jikos.suse.cz>
On Tuesday 03 April 2007 04:52, Jiri Kosina wrote:
> On Mon, 2 Apr 2007, Pete Zaitcev wrote:
>
> > How about this?
>
> Looks quite fine to me.
>
> But in case that Dmitry's patch "Input: add generic suspend and resume for
> uinput devices" fixes your issue too, I wouldn't merge it as it won't be
> needed. Could you please let me know?
Unfortunately my patch is crap. We should not be sending events down
dev->event() until dev->open() has been called because many drivers
start hardware from there and not ready until then.
So it is HID driver responsibility to properly reset leds after all.
--
Dmitry
next prev parent reply other threads:[~2007-04-05 3:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 17:59 usb hid: reset NumLock Pete Zaitcev
2007-03-30 18:14 ` Dmitry Torokhov
2007-03-30 19:54 ` Pete Zaitcev
2007-03-30 20:29 ` Dmitry Torokhov
2007-03-31 19:35 ` Jiri Kosina
2007-03-31 22:43 ` Pete Zaitcev
2007-04-02 5:24 ` Pete Zaitcev
2007-04-02 14:48 ` Jiri Kosina
2007-04-02 23:12 ` Pete Zaitcev
2007-04-03 5:04 ` Dmitry Torokhov
2007-04-03 6:24 ` Pete Zaitcev
2007-04-03 8:52 ` Jiri Kosina
2007-04-03 8:57 ` [linux-usb-devel] " Robert Marquardt
2007-04-03 9:32 ` Jiri Kosina
2007-04-05 3:24 ` Dmitry Torokhov [this message]
2007-04-05 8:50 ` Jiri Kosina
2007-04-05 20:38 ` Pete Zaitcev
2007-04-05 20:54 ` Dmitry Torokhov
2007-04-05 21:22 ` Pete Zaitcev
2007-04-01 11:49 ` Pekka Enberg
2007-04-01 16:16 ` Pete Zaitcev
2007-04-02 4:10 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704042324.56345.dtor@insightbb.com \
--to=dtor@insightbb.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=stuart_hayes@dell.com \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.