From: "Mark M. Hoffman" <mhoffman@lightlink.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] What about i2c_smbus_read_block_data() ?
Date: Thu, 05 Apr 2007 02:42:18 +0000 [thread overview]
Message-ID: <20070405024218.GD5464@jupiter.solarsys.private> (raw)
In-Reply-To: <200704042149.21264.hjk@linutronix.de>
Hello:
* Hans-Jürgen Koch <hjk@linutronix.de> [2007-04-04 23:32:34 +0200]:
> Am Mittwoch, 4. April 2007 21:49 schrieb Hans-Jürgen Koch:
> > I'm working on a driver for LM93. I've got some code by Mark Hoffman, (c)2004.
> > It doesn't compile on a recent kernel, because it heavily uses a function called
> > i2c_smbus_read_block_data(). Googling for that, I found this old mail in the
> > archives (October 2005):
> >
> > http://lists.lm-sensors.org/pipermail/lm-sensors/2005-October/013971.html
> >
> > Jean, what do you say to that today? Can we have that function back in
> > mainline, or do I have to find another solution?
> > If you agree to add it, I could prepare a patch for it, if you don't have
> > a recent version handy.
>
> Answering my own question: After looking at i2c-core.c et al., I find it quite
> obvious that this function should be added, if a driver needs it.
>
> I attached a patch that does this. Would that be acceptable? I can resend it
> when I have the LM93 patch ready.
I think if you put it in the same patchset with lm93.c, that will be fine.
Jean: I can do the initial review of this one for you when it's ready.
Regards,
--
Mark M. Hoffman
mhoffman@lightlink.com
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2007-04-05 2:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 19:49 [lm-sensors] What about i2c_smbus_read_block_data() ? Hans-Jürgen Koch
2007-04-04 21:32 ` Hans-Jürgen Koch
2007-04-05 2:42 ` Mark M. Hoffman [this message]
2007-04-08 8:58 ` Jean Delvare
2007-04-08 9:26 ` Hans-Jürgen Koch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070405024218.GD5464@jupiter.solarsys.private \
--to=mhoffman@lightlink.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.