From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [ANNOUNCE] new new aops patchset Date: Thu, 5 Apr 2007 09:58:13 +0200 Message-ID: <20070405075813.GB32379@wotan.suse.de> References: <20070402120934.GA19626@wotan.suse.de> <20070405001018.GK32602149@melbourne.sgi.com> <20070405021305.GD11192@wotan.suse.de> <20070405074529.GB25196@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Chinner , Linux Filesystems , Mark Fasheh , Steven Whitehouse To: Christoph Hellwig Return-path: Received: from mx1.suse.de ([195.135.220.2]:59784 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946061AbXDEH6g (ORCPT ); Thu, 5 Apr 2007 03:58:36 -0400 Content-Disposition: inline In-Reply-To: <20070405074529.GB25196@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Apr 05, 2007 at 08:45:29AM +0100, Christoph Hellwig wrote: > On Thu, Apr 05, 2007 at 04:13:05AM +0200, Nick Piggin wrote: > > > On a related note - what's the rules for a perform_write() implementation? > > > I noticed that wasn't documented with write_begin and write_end and > > > I don't see any other filesystem implementing it yet.... > > > > Ah, so it isn't, thanks I'll document it. (today I'm looking at doing a > > simple_perform_write and perhaps another easy one, which should also help > > filesystem maintainers to have a reference). > > I think ->perform_write should go away. It's really just duplicating > ->write for the !O_DIRECT case. Instead we should factor the remaining > bits of generic_file_aio_write into nice helpers so that people that don't > want to use the generic part can build their own ->write from these pieces. I probably don't disagree with you. If we use the iov_iter further down the stack (which I was going to do as a cleanup following this patchset), then you're right that it isn't too painful... Anyway, I'll leave it in the next release: I've converted a few users, so that will give people a better idea of whether they agree/disagree or don't care ;)