From: David Brownell <david-b@pacbell.net>
To: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] WATCHDOG: use base address from platform resources and make 2430 boot again
Date: Thu, 5 Apr 2007 13:13:17 -0700 [thread overview]
Message-ID: <200704051313.17697.david-b@pacbell.net> (raw)
In-Reply-To: <5d5443650704050642n2fcebf7dg34b5e94be428de96@mail.gmail.com>
On Thursday 05 April 2007 6:42 am, Trilok Soni wrote:
> Hi Nishanth,
>
> On 4/5/07, Nishanth Menon <menon.nishanth@gmail.com> wrote:
> > >
> > good catch.. missed that one.
>
> Nop. You have only made change in wdt_probe, but missed wdt_remove for
> setting drvdata to NULL. Please do the same there.
Actually drvata is undefined when there's no driver bound to a device.
So nulling it is not needed. It may make you worry less about memory
leakage (needless worries, right?), and isn't wrong -- not needed though.
prev parent reply other threads:[~2007-04-05 20:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-05 1:55 [PATCH] WATCHDOG: use base address from platform resources and make 2430 boot again nishanth menon
2007-04-05 3:55 ` OMAP2430 NAND Boot sathish.madhava
2007-04-05 11:16 ` Nishanth Menon
2007-04-05 10:20 ` [PATCH] WATCHDOG: use base address from platform resources and make 2430 boot again Trilok Soni
2007-04-05 12:43 ` Nishanth Menon
2007-04-05 13:00 ` Trilok Soni
2007-04-05 13:30 ` Tony Lindgren
2007-04-05 13:42 ` Trilok Soni
2007-04-05 17:27 ` [PATCH TRY2] " Nishanth Menon
2007-04-26 18:09 ` Tony Lindgren
2007-04-05 20:13 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704051313.17697.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.