From: Dave Jones <davej@redhat.com>
To: Mark Langsdorf <mark.langsdorf@amd.com>
Cc: cpufreq@lists.linux.org.uk
Subject: Re: [PATCH][retry] Report the number of processors in PowerNow-k8 correctly [2/2]
Date: Thu, 5 Apr 2007 16:29:58 -0400 [thread overview]
Message-ID: <20070405202958.GA28783@redhat.com> (raw)
In-Reply-To: <46096F1F.8030201@amd.com>
On Tue, Mar 27, 2007 at 02:23:11PM -0500, Mark Langsdorf wrote:
> The PowerNow! driver for Opteron reports the number of cores
> in the system, but claims to report the number of processors.
> Fix this minor cosmetic bug.
>
> Signed-Off-By: Bhavana Nagendra <bhavana.nagendra@amd.com>
> Acked-by: Mark Langsdorf <mark.langsdorf@amd.com>
>
> --- linux-2.6.18.x86_64/arch/i386/kernel/cpu/cpufreq/powernow-k8.c.orig
> 2007-03-22 16:13:04.630175768 -0500
> +++ linux-2.6.18.x86_64/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
> 2007-03-22 16:19:40.153047152 -0500
> @@ -840,7 +840,8 @@ static int powernow_k8_cpu_init_acpi(str
>
> /* fill in data */
> data->numps = data->acpi_data.state_count;
> - print_basics(data);
> + if (first_cpu(cpu_core_map[data->cpu]) == data->cpu)
> + print_basics(data);
> powernow_k8_acpi_pst_values(data, 0);
>
> /* notify BIOS that we exist */
Back from vacation..
I rolled both of these together into the same diff, as they're both
the same changelog, so it doesn't make a huge amount of sense to me
to have them as separate commits.
But sadly..
(16:23:19:davej@hera:cpufreq)$ git-applymbox -k ~/Mail/mbox
1 patch(es) to process.
Applying '[CPUFREQ] Report the number of processors in PowerNow-k8 correctly'
error: i386/kernel/cpu/cpufreq/powernow-k8.c: does not exist in index
Bah.. some hand fixing up of the path in the diff later..
(16:23:28:davej@hera:cpufreq)$ vim ~/Mail/mbox
(16:23:41:davej@hera:cpufreq)$ git-applymbox -k ~/Mail/mbox
1 patch(es) to process.
Applying '[CPUFREQ] Report the number of processors in PowerNow-k8 correctly'
error: patch failed: arch/i386/kernel/cpu/cpufreq/powernow-k8.c:661
error: arch/i386/kernel/cpu/cpufreq/powernow-k8.c: patch does not apply
I give up..
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-04-05 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-27 19:23 [PATCH][retry] Report the number of processors in PowerNow-k8 correctly [2/2] Mark Langsdorf
2007-04-05 20:29 ` Dave Jones [this message]
2007-04-05 21:21 ` [PATCH][retry 2] Report the number of processors in PowerNow-k8 correctly Mark Langsdorf
2007-04-05 21:30 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070405202958.GA28783@redhat.com \
--to=davej@redhat.com \
--cc=cpufreq@lists.linux.org.uk \
--cc=mark.langsdorf@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.