From: Nishanth Aravamudan <nacc@us.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: mchan@broadcom.com, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: tg3: unable to handle null pointer dereference
Date: Fri, 6 Apr 2007 18:53:01 -0700 [thread overview]
Message-ID: <20070407015301.GA9537@us.ibm.com> (raw)
In-Reply-To: <20070406.173600.38712619.davem@davemloft.net>
On 06.04.2007 [17:36:00 -0700], David Miller wrote:
> From: "Michael Chan" <mchan@broadcom.com>
> Date: Fri, 06 Apr 2007 15:57:13 -0700
>
> > On Fri, 2007-04-06 at 14:40 -0700, Nishanth Aravamudan wrote:
> >
> > > 2.6.21-rc5 is ok. 2.6.21-rc6 results in
> > >
> > > [ 14.241665] Unable to handle kernel NULL pointer dereference (address 0000000000000000)
> >
> > Sorry, I think this should fix it:
> >
> > [TG3]: Fix crash during tg3_init_one().
> >
> > The driver will crash when the chip has been initialized by EFI before
> > tg3_init_one(). In this case, the driver will call tg3_chip_reset()
> > before allocating consistent memory.
> >
> > The bug is fixed by checking for tp->hw_status before accessing it
> > during tg3_chip_reset().
> >
> > Signed-off-by: Michael Chan <mchan@broadcom.com>
>
> Applied, thanks Michael.
FWIW, tested, no panic.
Tested-by: Nishanth Aravamudan <nacc@us.ibm.com>
Thanks,
Nish
--
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center
next prev parent reply other threads:[~2007-04-07 1:55 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 2:50 Linux 2.6.21-rc6 Linus Torvalds
2007-04-06 21:40 ` tg3: unable to handle null pointer dereference [Re: Linux 2.6.21-rc6] Nishanth Aravamudan
2007-04-06 22:57 ` Michael Chan
2007-04-07 0:36 ` tg3: unable to handle null pointer dereference David Miller
2007-04-07 1:53 ` Nishanth Aravamudan [this message]
2007-04-06 22:44 ` Linux 2.6.21-rc6 - regressions update Soeren Sonnenburg
2007-04-06 23:04 ` Linus Torvalds
2007-04-07 8:12 ` [patch] high-res timers: UP resume fix Ingo Molnar
2007-04-07 8:25 ` Ingo Molnar
2007-04-07 8:48 ` Thomas Gleixner
2007-04-07 8:50 ` Ingo Molnar
2007-04-07 9:48 ` Rafael J. Wysocki
2007-04-07 9:47 ` Ingo Molnar
2007-04-07 9:51 ` Thomas Gleixner
2007-04-07 9:53 ` Rafael J. Wysocki
2007-04-11 14:00 ` Pavel Machek
2007-04-07 8:51 ` Thomas Gleixner
2007-04-07 9:49 ` [patch] high-res timers: " Ingo Molnar
2007-04-07 10:02 ` Rafael J. Wysocki
2007-04-07 10:05 ` [patch, take #3] " Ingo Molnar
2007-04-07 10:45 ` Soeren Sonnenburg
2007-04-08 15:57 ` Linux 2.6.21-rc6 - regressions update Soeren Sonnenburg
2007-04-07 8:48 ` Linux 2.6.21-rc6 Michal Piotrowski
2007-04-07 18:37 ` Randy Dunlap
2007-04-07 18:46 ` Linus Torvalds
2007-04-07 18:50 ` Randy Dunlap
2007-04-07 18:51 ` Linus Torvalds
2007-04-07 20:58 ` Gene Heskett
2007-04-08 23:09 ` Andrew Morton
2007-04-09 0:42 ` Greg KH
2007-04-09 0:59 ` Jeff Garzik
2007-04-10 7:57 ` Chris Wedgwood
2007-04-11 7:38 ` Ingo Molnar
2007-04-10 3:32 ` Dmitry Torokhov
2007-04-10 14:35 ` Jeff Chua
2007-04-10 15:35 ` Linus Torvalds
2007-04-12 4:16 ` Jeff Chua
2007-04-12 9:55 ` [new 2.6.21-rc6 crash] BUG: unable to handle kernel paging request at virtual address 6b6b6ceb Ingo Molnar
2007-04-12 15:14 ` Linux 2.6.21-rc6 Mattia Dongili
2007-04-12 17:02 ` Mattia Dongili
2007-04-12 18:26 ` Maxim Levitsky
2007-04-13 8:52 ` Mattia Dongili
2007-04-13 21:29 ` Tobias Diedrich
2007-04-13 23:50 ` Adrian Bunk
2007-04-14 6:50 ` Tobias Diedrich
2007-04-14 6:50 ` Tobias Diedrich
2007-04-14 8:16 ` Tobias Diedrich
2007-04-14 9:05 ` Rafael J. Wysocki
2007-04-14 9:05 ` Rafael J. Wysocki
2007-04-14 10:32 ` Tobias Diedrich
2007-04-14 12:26 ` Adrian Bunk
2007-04-14 12:09 ` Tobias Diedrich
2007-04-14 12:09 ` Tobias Diedrich
2007-04-14 12:24 ` Tobias Diedrich
2007-04-14 12:24 ` Tobias Diedrich
2007-04-14 12:31 ` Tobias Diedrich
2007-04-14 13:00 ` Adrian Bunk
2007-04-14 18:28 ` Rafael J. Wysocki
2007-04-14 18:28 ` Rafael J. Wysocki
2007-04-14 19:56 ` Tobias Diedrich
2007-04-14 19:56 ` Tobias Diedrich
2007-04-14 20:23 ` Rafael J. Wysocki
2007-04-14 20:23 ` Rafael J. Wysocki
2007-04-14 20:25 ` Adrian Bunk
2007-04-14 20:25 ` Adrian Bunk
2007-04-14 20:38 ` Rafael J. Wysocki
2007-04-14 20:38 ` Rafael J. Wysocki
2007-04-14 21:35 ` Tobias Diedrich
2007-04-14 21:35 ` Tobias Diedrich
2007-04-14 21:58 ` Rafael J. Wysocki
2007-04-14 21:58 ` Rafael J. Wysocki
2007-04-15 7:38 ` Tobias Diedrich
2007-04-15 7:38 ` Tobias Diedrich
2007-04-15 8:02 ` Tobias Diedrich
2007-04-15 8:02 ` Tobias Diedrich
2007-04-15 11:16 ` Rafael J. Wysocki
2007-04-15 14:19 ` Dmitry Torokhov
2007-04-15 14:19 ` Dmitry Torokhov
2007-04-15 15:52 ` Rafael J. Wysocki
2007-04-15 15:52 ` Rafael J. Wysocki
2007-04-15 18:50 ` Tobias Diedrich
2007-04-15 19:37 ` Rafael J. Wysocki
2007-04-15 19:37 ` Rafael J. Wysocki
2007-04-15 15:14 ` David Brownell
2007-04-15 15:14 ` [linux-pm] " David Brownell
2007-04-15 16:37 ` Rafael J. Wysocki
2007-04-15 16:37 ` [linux-pm] " Rafael J. Wysocki
2007-04-15 17:53 ` David Brownell
2007-04-15 17:53 ` [linux-pm] " David Brownell
2007-04-15 19:40 ` Tobias Diedrich
2007-04-15 19:54 ` Rafael J. Wysocki
2007-04-15 19:54 ` [linux-pm] " Rafael J. Wysocki
2007-04-25 17:14 ` Tobias Diedrich
2007-04-25 19:36 ` Rafael J. Wysocki
2007-04-25 19:36 ` [linux-pm] " Rafael J. Wysocki
2007-04-25 20:09 ` Tobias Diedrich
2007-04-14 0:36 ` [1/3] 2.6.21-rc6: known regressions Adrian Bunk
2007-04-14 1:34 ` Linus Torvalds
2007-04-14 1:49 ` Brandeburg, Jesse
2007-04-14 4:25 ` David Miller
2007-04-14 5:07 ` Ian McDonald
2007-04-14 5:29 ` David Miller
2007-04-14 6:21 ` Ingo Molnar
2007-04-14 7:25 ` Greg KH
2007-04-20 13:39 ` Ingo Molnar
2007-04-20 13:46 ` Ingo Molnar
2007-04-14 0:38 ` [2/3] " Adrian Bunk
2007-04-14 13:17 ` [v4l-dvb-maintainer] " Mauro Carvalho Chehab
2007-04-14 0:38 ` [3/3] " Adrian Bunk
2007-04-14 1:57 ` Antonino A. Daplas
2007-04-14 1:57 ` Antonino A. Daplas
2007-04-15 16:26 ` Marcus Better
2007-04-15 16:26 ` Marcus Better
2007-04-15 23:08 ` Antonino A. Daplas
2007-04-15 23:08 ` Antonino A. Daplas
2007-04-16 6:23 ` Marcus Better
2007-04-16 6:45 ` Antonino A. Daplas
2007-04-16 6:45 ` Antonino A. Daplas
2007-04-17 8:17 ` Marcus Better
2007-04-17 8:17 ` Marcus Better
2007-04-17 9:27 ` Antonino A. Daplas
2007-04-17 11:54 ` Marcus Better
2007-04-17 11:54 ` Marcus Better
2007-04-24 15:33 ` Pavel Machek
2007-04-14 7:24 ` Tobias Doerffel
2007-04-14 7:40 ` Dave Jones
2007-04-14 7:40 ` Dave Jones
2007-04-15 17:15 ` Jeff Chua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070407015301.GA9537@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.