From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch 2/4] clean up identify_cpu Date: Sat, 7 Apr 2007 02:14:01 -0700 Message-ID: <20070407021401.a993892b.akpm@linux-foundation.org> References: <20070406224152.556848893@goop.org> <20070406224204.782242327@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20070406224204.782242327@goop.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Jeremy Fitzhardinge Cc: virtualization@lists.osdl.org, lkml List-Id: virtualization@lists.linuxfoundation.org On Fri, 06 Apr 2007 15:41:54 -0700 Jeremy Fitzhardinge wr= ote: > identify_cpu() is used to identify both the boot CPU and secondary > CPUs, but it performs some actions which only apply to the boot CPU. > Those functions are therefore really __init functions, but because > they're called by identify_cpu(), they must be marked __cpuinit. > = > This patch splits identify_cpu() into identify_boot_cpu() and > identify_secondary_cpu(), and calls the appropriate init functions > from each. Also, identify_boot_cpu() and all the functions it > dominates are marked __init. x86_64 uses this too. WARNING: arch/x86_64/kernel/built-in.o - Section mismatch: reference to .in= it.text:mtrr_bp_init from .text.identify_cpu after 'identify_cpu' (at offse= t 0x655) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965662AbXDGJOK (ORCPT ); Sat, 7 Apr 2007 05:14:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965679AbXDGJOK (ORCPT ); Sat, 7 Apr 2007 05:14:10 -0400 Received: from smtp.osdl.org ([65.172.181.24]:48696 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965662AbXDGJOI (ORCPT ); Sat, 7 Apr 2007 05:14:08 -0400 Date: Sat, 7 Apr 2007 02:14:01 -0700 From: Andrew Morton To: Jeremy Fitzhardinge Cc: Andi Kleen , virtualization@lists.osdl.org, lkml Subject: Re: [patch 2/4] clean up identify_cpu Message-Id: <20070407021401.a993892b.akpm@linux-foundation.org> In-Reply-To: <20070406224204.782242327@goop.org> References: <20070406224152.556848893@goop.org> <20070406224204.782242327@goop.org> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 06 Apr 2007 15:41:54 -0700 Jeremy Fitzhardinge wrote: > identify_cpu() is used to identify both the boot CPU and secondary > CPUs, but it performs some actions which only apply to the boot CPU. > Those functions are therefore really __init functions, but because > they're called by identify_cpu(), they must be marked __cpuinit. > > This patch splits identify_cpu() into identify_boot_cpu() and > identify_secondary_cpu(), and calls the appropriate init functions > from each. Also, identify_boot_cpu() and all the functions it > dominates are marked __init. x86_64 uses this too. WARNING: arch/x86_64/kernel/built-in.o - Section mismatch: reference to .init.text:mtrr_bp_init from .text.identify_cpu after 'identify_cpu' (at offset 0x655)