From: Srivatsa Vaddagiri <vatsa@in.ibm.com>
To: menage@google.com
Cc: akpm@linux-foundation.org, sekharan@us.ibm.com, dev@sw.ru,
xemul@sw.ru, serue@us.ibm.com, ebiederm@xmission.com,
ckrm-tech@lists.sourceforge.net, linux-kernel@vger.kernel.org,
containers@lists.osdl.org, mbligh@google.com,
rohitseth@google.com, devel@openvz.org
Subject: Re: [PATCH 3/7] Containers (V8): Add generic multi-subsystem API to containers
Date: Sat, 7 Apr 2007 09:48:51 +0530 [thread overview]
Message-ID: <20070407041851.GA15007@in.ibm.com> (raw)
In-Reply-To: <20070407001324.271959000@menage.corp.google.com>
On Fri, Apr 06, 2007 at 04:32:24PM -0700, menage@google.com wrote:
> +static int attach_task(struct container *cont, struct task_struct *tsk)
> {
[snip]
> + task_lock(tsk);
You need to check here if task state is PF_EXITING and fail with
-ESRCH if so? Otherwise we risk breaking refcount on
init_container_group.
> + rcu_assign_pointer(tsk->containers, newcg);
> + task_unlock(tsk);
--
Regards,
vatsa
next prev parent reply other threads:[~2007-04-07 4:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 23:32 [PATCH 0/7] Containers (V8): Generic Process Containers menage
2007-04-06 23:32 ` [PATCH 1/7] Containers (V8): Generic container system abstracted from cpusets code menage
2007-04-06 23:32 ` [PATCH 2/7] Containers (V8): Cpusets hooked into containers menage
2007-04-23 10:52 ` Vaidyanathan Srinivasan
2007-04-25 4:59 ` Paul Menage
2007-04-06 23:32 ` [PATCH 4/7] Containers (V8): Simple CPU accounting container subsystem menage
2007-04-10 13:16 ` Srivatsa Vaddagiri
2007-04-06 23:32 ` [PATCH 5/7] Containers (V8): Resource Groups over generic containers menage
2007-04-06 23:32 ` [PATCH 6/7] Containers (V8): BeanCounters over generic process containers menage
2007-04-09 7:46 ` Pavel Emelianov
2007-04-09 16:44 ` William Lee Irwin III
2007-04-06 23:32 ` [PATCH 7/7] Containers (V8): Container interface to nsproxy subsystem menage
[not found] ` <20070407001324.271959000@menage.corp.google.com>
2007-04-07 1:58 ` [ckrm-tech] [PATCH 3/7] Containers (V8): Add generic multi-subsystem API to containers Paul Menage
2007-04-07 4:18 ` Srivatsa Vaddagiri [this message]
2007-04-07 17:30 ` Paul Menage
2007-04-10 14:42 ` Srivatsa Vaddagiri
2007-04-10 14:52 ` Srivatsa Vaddagiri
2007-04-10 15:45 ` [ckrm-tech] " Paul Menage
2007-04-11 4:47 ` Srivatsa Vaddagiri
2007-04-11 5:01 ` Srivatsa Vaddagiri
2007-04-11 8:42 ` Paul Menage
2007-04-11 16:42 ` Srivatsa Vaddagiri
2007-04-23 11:07 ` [PATCH 0/7] Containers (V8): Generic Process Containers Vaidyanathan Srinivasan
2007-04-25 5:04 ` [ckrm-tech] " Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070407041851.GA15007@in.ibm.com \
--to=vatsa@in.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=ckrm-tech@lists.sourceforge.net \
--cc=containers@lists.osdl.org \
--cc=dev@sw.ru \
--cc=devel@openvz.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@google.com \
--cc=menage@google.com \
--cc=rohitseth@google.com \
--cc=sekharan@us.ibm.com \
--cc=serue@us.ibm.com \
--cc=xemul@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.