From: David Miller <davem@davemloft.net>
To: bryan.wu@analog.com
Cc: alan@lxorguk.ukuu.org.uk, waltje@uWalt.NL.Mugnet.ORG,
aubreylee@gmail.com, netdev@vger.kernel.org, akpm@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU
Date: Mon, 09 Apr 2007 11:43:23 -0700 (PDT) [thread overview]
Message-ID: <20070409.114323.78734391.davem@davemloft.net> (raw)
In-Reply-To: <20070409.095523.122833625.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Mon, 09 Apr 2007 09:55:23 -0700 (PDT)
> From: "Wu, Bryan" <bryan.wu@analog.com>
> Date: Mon, 09 Apr 2007 17:50:22 +0800
>
> > On Mon, 2007-04-09 at 11:01 +0800, Aubrey Li wrote:
> > > The option CONFIG_PACKET_MMAP should depend on MMU.
> > >
> > > Signed-off-by: Aubrey.Li <aubreylee@gmail.com>
> > > ---
> > > net/packet/Kconfig | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/net/packet/Kconfig b/net/packet/Kconfig
> > > index 34ff93f..959c272 100644
> > > --- a/net/packet/Kconfig
> > > +++ b/net/packet/Kconfig
> > > @@ -17,7 +17,7 @@ config PACKET
> > >
> > > config PACKET_MMAP
> > > bool "Packet socket: mmapped IO"
> > > - depends on PACKET
> > > + depends on PACKET && MMU
> > > help
> > > If you say Y here, the Packet protocol driver will use an IO
> > > mechanism that results in faster communication.
> >
> > Yeah, this is a bug found on blackfin arch and it is also for other
> > NOMMU arch. Is there any solution for this? We think Aubrey's idea
> > works.
>
> I will apply this patch.
Actually I won't, the other comments in this thread make a lot
of sense, we should try to make it build and work just as we
do for other similar things on no-MMU.
next prev parent reply other threads:[~2007-04-09 18:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-09 3:01 [PATCH] CONFIG_PACKET_MMAP should depend on MMU Aubrey Li
2007-04-09 9:50 ` Wu, Bryan
2007-04-09 15:46 ` Robin Getz
2007-04-10 12:55 ` David Howells
2007-04-10 23:52 ` Robin Getz
2007-04-17 10:36 ` Aubrey Li
2007-04-17 18:30 ` Robin Getz
2007-04-17 19:02 ` David Howells
2007-04-18 15:33 ` David Howells
2007-04-19 0:59 ` Aubrey Li
2007-04-19 9:42 ` David Howells
2007-04-20 4:46 ` Aubrey Li
2007-04-20 7:58 ` David Howells
2007-04-20 8:39 ` Aubrey Li
2007-04-20 8:58 ` David Howells
2007-04-20 9:17 ` Eric Dumazet
2007-04-20 10:43 ` David Howells
2007-04-20 13:14 ` Aubrey Li
2007-04-09 16:55 ` David Miller
2007-04-09 18:43 ` David Miller [this message]
2007-04-09 20:08 ` Robin Getz
2007-04-10 2:00 ` Wu, Bryan
-- strict thread matches above, loose matches on Subject: below --
2006-04-11 4:22 Aubrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070409.114323.78734391.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=aubreylee@gmail.com \
--cc=bryan.wu@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=waltje@uWalt.NL.Mugnet.ORG \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.