From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthew Wilcox <matthew@wil.cx>
Date: Mon, 09 Apr 2007 21:41:33 +0000
Subject: Re: [KJ] [PATCH] include KERN_* constant in printk() calls in
Message-Id: <20070409214132.GC26692@parisc-linux.org>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20070409194151.GG4262@traven>
In-Reply-To: <20070409194151.GG4262@traven>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kernel-janitors@vger.kernel.org

On Mon, Apr 09, 2007 at 10:53:21PM +0200, Matthias Kaehlcke wrote:
> here comes v0.02 of the patch, i hope it is more useful than the first
> one

You've made the lines go beyond 80 columns.

>  		if (res) {
> -			printk("SLAB: cache with size %d has lost its name\n",
> +			printk(KERN_ERR "SLAB: cache with size %d has lost its name\n",
>  			       pc->buffer_size);
>  			continue;

Try this instead:

+			printk(KERN_ERR "SLAB: cache with size %d has lost its"
+				" name\n", pc->buffer_size);


(ditto the other changes you made).
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors