All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomash Brechko <tomash.brechko@gmail.com>
To: git@vger.kernel.org, Catalin Marinas <catalin.marinas@gmail.com>
Subject: Re: [PATCH (resend)] Pass -C1 to git-apply in StGIT's apply_diff() and apply_patch().
Date: Tue, 10 Apr 2007 23:32:14 +0400	[thread overview]
Message-ID: <20070410193214.GF4946@moonlight.home> (raw)
In-Reply-To: <20070410192130.GE4946@moonlight.home>

On Tue, Apr 10, 2007 at 23:21:30 +0400, Tomash Brechko wrote:
> But I see your point, and back then I didn't realize how it will
> affect the 'push' command.
> 
> So, I think the best would be to have 'pull'-like commands (pull,
> rebase, import, fold, sync) to be liberal by default (accept pathes
> with -C1), while 'push'-like commands (push, any other?) to be
> conservative (require full context match).  And both classes should
> provide the way to explicitly control acceptance level.

Please disregard this part.  It's late here, and I mistook StGIT's
push for GIT's push.  Once we are talking about StGIT's push (push of
the patch back to the stack), why would we want to start tree-way
merge when the context has changed?  My point was exactly that since I
want to keep my patches up-to-date with the main branch, I do rebase
from time to time, and I'm not interested in doing the merge every
time just because something has changed upstream in surrounding code.

The same goes for patches that were already applied upstream.
Whatever the current context around the code of my applied patch is, I
have to accept it, because the patch was applied.  I'm going to throw
it away locally, but currently I have to do the merge first.

I think I didn't get you point.


-- 
   Tomash Brechko

  reply	other threads:[~2007-04-10 19:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-09 11:24 [PATCH (resend)] Pass -C1 to git-apply in StGIT's apply_diff() and apply_patch() Tomash Brechko
2007-04-10 16:48 ` Catalin Marinas
2007-04-10 19:21   ` Tomash Brechko
2007-04-10 19:32     ` Tomash Brechko [this message]
2007-04-10 22:38       ` Catalin Marinas
2007-04-11  7:51         ` Tomash Brechko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070410193214.GF4946@moonlight.home \
    --to=tomash.brechko@gmail.com \
    --cc=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.