All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akinobu Mita <mita@fixstars.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
	cbe-oss-dev@ozlabs.org
Subject: Re: [patch 1/3] powerpc: delete -mstring option
Date: Wed, 11 Apr 2007 11:35:08 +0900	[thread overview]
Message-ID: <20070411023508.GA2197@localhost.localdomain> (raw)
In-Reply-To: <4FDD7344-D9AD-4DCF-8C10-E65B6CEC7762@kernel.crashing.org>

On Tue, Apr 10, 2007 at 01:42:15PM -0500, Kumar Gala wrote:
> >This is the right solution, thank you for the patch.
> >But please fold these two together so that you're not
> >introducing a regression halfway the patch series.
> 
> I agree this looks good and merge patches 1/3 and 2/3 into a single  
> patch.

Thansk, this is updated patch.

From: Akinobu Mita <mita@fixstars.com>
Subject: powerpc: delete -mstring option

There is no reason to force -mstring option.

This patch removes -mstring option, and adds -mno-string option
for FLS_BOOKE (Because GCC is now putting string instructions
even if you don't specify -mstring).

Signed-off-by: Akinobu Mita <mita@fixstars.com>

---
 arch/powerpc/Makefile |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: 2.6-git-ps3/arch/powerpc/Makefile
===================================================================
--- 2.6-git-ps3.orig/arch/powerpc/Makefile
+++ 2.6-git-ps3/arch/powerpc/Makefile
@@ -102,8 +102,8 @@ CFLAGS += $(call cc-option,-mno-altivec)
 # kernel considerably.
 CFLAGS += $(call cc-option,-funit-at-a-time)
 
-ifndef CONFIG_FSL_BOOKE
-CFLAGS		+= -mstring
+ifeq ($(CONFIG_FSL_BOOKE),y)
+CFLAGS         += -mno-string
 endif
 
 ifeq ($(CONFIG_6xx),y)

      reply	other threads:[~2007-04-11  2:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-10 11:13 [patch 1/3] powerpc: delete -mstring option Akinobu Mita
2007-04-10 12:47 ` Segher Boessenkool
2007-04-10 18:42   ` Kumar Gala
2007-04-11  2:35     ` Akinobu Mita [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070411023508.GA2197@localhost.localdomain \
    --to=mita@fixstars.com \
    --cc=arnd@arndb.de \
    --cc=cbe-oss-dev@ozlabs.org \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.