All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] Taking a closer look at lm-sensors,
Date: Thu, 12 Apr 2007 07:13:54 +0000	[thread overview]
Message-ID: <20070412091354.10f4bef7@hyperion.delvare> (raw)

Hi Hans,

On Mon, 09 Apr 2007 16:03:11 +0200, Hans de Goede wrote:
> Because of the integration of the dynamic chip support written by my students, 
> I've been taking a (much) closer look at lm-sensors userspace.
> 
> The current makefile is broken for use by any serious distribution / any 
> distribution will need to patch it.
> 
> Why? Well because of the abundant use of ":=" instead of "="
> 
> For example the Makefile says:
> "PREFIX := /usr/local"
> 
> Now when one wants an other prefix, normally in the build script for the distro 
> one would invoke make like this:
> 
> make PREFIX=/usr
> 
> however because of the unnecessary use of :=, this isn;'t work as := will 
> overwrite any environment / make commandline settings. This leads to distro's 
> using patches to the makefile like the one attached.

Missing attachment.

> Is it ok if I fix this in the 3.0.0 branch?

I would need to be convinced that this needs to be fixed first. I wrote
a minimal Makefile for testing purposes as follows:

--- 8< ---
PREFIX := /usr/local
BINDIR := $(PREFIX)/bin

all :
	@echo $(PREFIX)
	@echo $(BINDIR)
--- 8< ---

khali@hyperion:~/tmp> make
/usr/local
/usr/local/bin
khali@hyperion:~/tmp> make PREFIX=/usr
/usr
/usr/bin
khali@hyperion:~/tmp>

This is with GNU make 3.81, but I also tested with 3.80 and 3.78.1 with
the same result. So ":=" seems to allow variable value override from
the command line just fine, and I fail to see why a distribution would
need to patch our Makefile. In fact I just tried a "make PREFIX=/foo
user_install" and it installed lm-sensors in /foo just fine. So what's
the problem exactly?

Checking the Slackware and openSuse lm-sensors package sources, I see
that they do indeed patch our Makefile to change the prefix and other
variables. But given my tests above, this seems to be by choice, and I
doubt they would do it any differently if we were using "=" instead of
":=" in the Makefile.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

             reply	other threads:[~2007-04-12  7:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-12  7:13 Jean Delvare [this message]
2007-04-12 10:07 ` [lm-sensors] Taking a closer look at lm-sensors, Hans de Goede
2007-04-13  6:51 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070412091354.10f4bef7@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.