From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Anton Vorontsov <cbou@mail.ru>
Cc: linux-kernel@vger.kernel.org, kernel-discuss@handhelds.org
Subject: Re: [PATCH 5/7] [RFC] ds2760 W1 slave
Date: Thu, 12 Apr 2007 18:20:23 +0400 [thread overview]
Message-ID: <20070412142023.GA18134@2ka.mipt.ru> (raw)
In-Reply-To: <20070412140807.GA25532@zarina>
On Thu, Apr 12, 2007 at 06:08:07PM +0400, Anton Vorontsov (cbou@mail.ru) wrote:
> > > +int w1_ds2760_read(struct device *dev, char *buf, int addr, size_t count)
> > > +{
> > > + return w1_ds2760_io(dev, buf, addr, count, 0);
> > > +}
> > > +
> > > +int w1_ds2760_write(struct device *dev, char *buf, int addr, size_t count)
> > > +{
> > > + return w1_ds2760_io(dev, buf, addr, count, 1);
> > > +}
> >
> > Both are exported, who use them?
>
> ds2760_battery driver. W1 does not have any API to "talk" to w1 slaves
> in generic manner (at least I didn't found any).
> So, ds2760_battery using it.
It was - bus masters were accessed through generic find_bus() via
device/driver model, bus master has links to all devices found on
controlled bus.
But find_bus() was removed, so there is no such mechanism right now.
I have no objections against this driver, feel free to add my ack (when
trivialities described are resolved) or I can push w1 part myself.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2007-04-12 14:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-11 23:25 [PATCH 5/7] [RFC] ds2760 W1 slave Anton Vorontsov
2007-04-12 7:08 ` Evgeniy Polyakov
2007-04-12 14:08 ` Anton Vorontsov
2007-04-12 14:20 ` Evgeniy Polyakov [this message]
2007-04-12 15:47 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070412142023.GA18134@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=cbou@mail.ru \
--cc=kernel-discuss@handhelds.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.