All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Fix use of "void *" for block dev read/write buffer pointers
Date: Fri, 13 Apr 2007 09:18:41 +0200	[thread overview]
Message-ID: <200704130918.42688.sr@denx.de> (raw)
In-Reply-To: <528646bc0704122354k24467ee6oc1951b46e32df1df@mail.gmail.com>

Hi All,

On Friday 13 April 2007 08:54, Grant Likely wrote:
> > > Denis, could you please take a look at this patch and let me know if
> > > this patch supersedes your patch:
> > >
> > > "Re: [U-Boot-Users] [PATCH] Fix bugs in cmd_ide.c and cmd_scsi.c"
> > >
> > > from April, 2nd?
> >
> > My patch from April, 2nd, fixes this issue already. In my patch I decided
> > to just cast the pointer back to ulong *, since I don't know if it is a
> > good idea to increment a pointer to void *.
>
> Incrementing a void* is safe.
>
> Personally, I prefer the solution in Greg's patch.

I appied Greg's patch and the device# part of Denis's patch to my 
u-boot-ppc4xx repository. Please give it a try and let me know if the issues 
are fixed now:

git://www.denx.de/git/u-boot-ppc4xx.git

Then I'll ask Wolfgang to pull from my repository.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
=====================================================================

  reply	other threads:[~2007-04-13  7:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-12 15:28 [U-Boot-Users] [PATCH] Fix use of "void *" for block dev read/write buffer pointers Greg Lopp
2007-04-12 16:33 ` Grant Likely
2007-04-12 19:07   ` Greg Lopp
2007-04-12 19:49     ` Grant Likely
2007-04-12 20:03       ` Greg Lopp
     [not found]         ` <1176408946.14027.41.camel@saruman.qstreams.net>
2007-04-12 20:25           ` Grant Likely
2007-04-12 20:27         ` Grant Likely
2007-04-13  5:56           ` Stefan Roese
2007-04-13  6:45             ` Denis Peter
2007-04-13  6:54               ` Grant Likely
2007-04-13  7:18                 ` Stefan Roese [this message]
2007-04-13 11:19                   ` Denis Peter
2007-04-13 17:22               ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704130918.42688.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.