From: Christoph Hellwig <hch@infradead.org>
To: "Cameron, Steve" <Steve.Cameron@hp.com>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
"Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net>,
akpm@linux-foundation.org, jens.axboe@oracle.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/1] cciss: kconfig patch to make cciss dependent onscsi for SG_IO ioctl
Date: Fri, 13 Apr 2007 14:21:07 +0100 [thread overview]
Message-ID: <20070413132107.GA3702@infradead.org> (raw)
In-Reply-To: <558F4D473FD7FE419B019232BF2D37B40B2472@G3W0634.americas.hpqcorp.net>
On Fri, Apr 13, 2007 at 01:58:41PM +0100, Cameron, Steve wrote:
>
> Well, with SCSI turned off, it didn't compile:
>
>
> drivers/block/cciss.c: In function `cciss_ioctl':
> drivers/block/cciss.c:1180: error: `SCSI_IOCTL_GET_IDLUN' undeclared (first use in this function)
> drivers/block/cciss.c:1180: error: (Each undeclared identifier is reported only once
> drivers/block/cciss.c:1180: error: for each function it appears in.)
> drivers/block/cciss.c:1181: error: `SCSI_IOCTL_GET_BUS_NUMBER' undeclared (first use in this function)
The two are defined in scsi/scsi.h unconditionally. Make sure to add
an unconditional include of that header to your driver, apparently you're
only picking it up by accident when CONFIG_SCSI is enabled.
next prev parent reply other threads:[~2007-04-13 13:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-12 21:27 [PATCH 1/1] cciss: kconfig patch to make cciss dependent on scsi for SG_IO ioctl Mike Miller (OS Dev)
2007-04-12 22:07 ` James Bottomley
2007-04-13 12:58 ` [PATCH 1/1] cciss: kconfig patch to make cciss dependent onscsi " Cameron, Steve
2007-04-13 12:58 ` Cameron, Steve
2007-04-13 13:21 ` Christoph Hellwig [this message]
2007-04-13 13:22 ` Cameron, Steve
2007-04-13 13:22 ` Cameron, Steve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070413132107.GA3702@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=Steve.Cameron@hp.com \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mikem@beardog.cca.cpqcorp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.