From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH-UPDATE]: Changes after retracting timestamping patches
Date: Fri, 13 Apr 2007 18:14:58 +0000 [thread overview]
Message-ID: <200704131914.59121@strip-the-willow> (raw)
In-Reply-To: <200704131825.14989@strip-the-willow>
| The fix is in using dccp_timestamp, as in all other patches I have been updating
| over the day. Will send this update shortly.
I have verified this - the patch set is correct. The initial RTT estimate taken from
the Request/Response exchange in net/dccp/input.c
The reason is that the patch "Cheaper & smaller timestamping" (6b) has been retracted,
i.e. the following change no longer applies
--- a/net/dccp/input.c
+++ b/net/dccp/input.c
@@ -304,7 +304,7 @@ static int dccp_rcv_request_sent_state_p
if (dp->dccps_options_received.dccpor_timestamp_echo) {
struct timeval now;
- dccp_timestamp(sk, &now);
+ do_gettimeofday(&now);
dp->dccps_syn_rtt = dccp_sample_rtt(sk, &now, NULL);
}
=> Which means that all timestamps are relative to dccps_epoch.
To be extra safe, I just did a test run and got
Apr 13 19:11:41 kernel: [ 3171.585188] ccid3_hc_tx_send_packet: SYN RTT = 321us
So this does work.
However, the RTTs now grow to big fat values such as several seconds. Can't help it,
that is the price of not using a realtime operating system.
prev parent reply other threads:[~2007-04-13 18:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-13 17:25 [PATCH-UPDATE]: Changes after retracting timestamping patches Gerrit Renker
2007-04-13 17:38 ` Arnaldo Carvalho de Melo
2007-04-13 17:52 ` Gerrit Renker
2007-04-13 18:14 ` Gerrit Renker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704131914.59121@strip-the-willow \
--to=gerrit@erg.abdn.ac.uk \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.