All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, Patrick McHardy <kaber@trash.net>
Subject: [NETLINK 00/04]: Consistent dump callback locking
Date: Mon, 16 Apr 2007 09:51:51 +0200 (MEST)	[thread overview]
Message-ID: <20070416074949.19262.73702.sendpatchset@localhost.localdomain> (raw)

These patches change netlink to provide consistent locking in dump callbacks.
Currently the first invocation of the callbacks happens under the queue
processing mutex and ->cb_lock of the dumping socket, further invocations only
under cb_lock. The first patch replaces the cb_lock spinlock by a mutex and
allows netlink_kernel_create users to override it with a subsystem specific
mutex, the second patch makes use of this for rtnetlink. The third and fourth
patches remove some locking that is not needed anymore.

Please apply, thanks.


 drivers/connector/connector.c       |    2 -
 drivers/scsi/scsi_netlink.c         |    3 +-
 drivers/scsi/scsi_transport_iscsi.c |    2 -
 fs/ecryptfs/netlink.c               |    2 -
 include/linux/netlink.h             |    5 +++-
 include/net/pkt_sched.h             |    2 -
 kernel/audit.c                      |    2 -
 lib/kobject_uevent.c                |    2 -
 net/bridge/br_netlink.c             |    2 -
 net/bridge/netfilter/ebt_ulog.c     |    2 -
 net/core/fib_rules.c                |    4 ---
 net/core/rtnetlink.c                |   12 ++++++-----
 net/decnet/dn_dev.c                 |    3 --
 net/decnet/netfilter/dn_rtmsg.c     |    2 -
 net/ipv4/devinet.c                  |   12 +----------
 net/ipv4/fib_frontend.c             |    3 +-
 net/ipv4/inet_diag.c                |    2 -
 net/ipv4/netfilter/ip_queue.c       |    2 -
 net/ipv4/netfilter/ipt_ULOG.c       |    2 -
 net/ipv6/addrconf.c                 |    2 -
 net/ipv6/netfilter/ip6_queue.c      |    2 -
 net/netfilter/nfnetlink.c           |    2 -
 net/netlink/af_netlink.c            |   38 +++++++++++++++++++++---------------
 net/netlink/genetlink.c             |    2 -
 net/sched/cls_api.c                 |    2 -
 net/sched/sch_api.c                 |   22 ++------------------
 net/sched/sch_generic.c             |   29 ++++++---------------------
 net/xfrm/xfrm_user.c                |    2 -
 security/selinux/netlink.c          |    2 -
 29 files changed, 66 insertions(+), 103 deletions(-)

Patrick McHardy (4):
      [NETLINK]: Switch cb_lock spinlock to mutex and allow to override it
      [RTNETLINK]: Hold rtnl_mutex during netlink dump callbacks
      [RTNETLINK]: Remove unnecessary locking in dump callbacks
      [NET_SCHED]: Eliminate qdisc_tree_lock

             reply	other threads:[~2007-04-16  7:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-16  7:51 Patrick McHardy [this message]
2007-04-16  7:51 ` [NETLINK 01/04]: Switch cb_lock spinlock to mutex and allow to override it Patrick McHardy
2007-04-16 23:55   ` David Miller
2007-04-17 10:40     ` Patrick McHardy
2007-04-16  7:51 ` [RTNETLINK 02/04]: Hold rtnl_mutex during netlink dump callbacks Patrick McHardy
2007-04-16 23:59   ` David Miller
2007-04-16  7:51 ` [RTNETLINK 03/04]: Remove unnecessary locking in " Patrick McHardy
2007-04-17  0:01   ` David Miller
2007-04-16  7:51 ` [NET_SCHED 04/04]: Eliminate qdisc_tree_lock Patrick McHardy
2007-04-17  0:06   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070416074949.19262.73702.sendpatchset@localhost.localdomain \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.