From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Olof Johansson <olof@lixom.net>, paulus@samba.org
Subject: Re: [PATCH] [5/5] pasemi: GPIO MDIO of_platform driver
Date: Tue, 17 Apr 2007 01:07:12 +0200 [thread overview]
Message-ID: <200704170107.12709.arnd@arndb.de> (raw)
In-Reply-To: <20070416063139.GC20319@lixom.net>
On Monday 16 April 2007, Olof Johansson wrote:
> +static int __devinit hack_init(void)
> +{
> +=A0=A0=A0=A0=A0=A0=A0struct platform_device *pdev;
> +
> +=A0=A0=A0=A0=A0=A0=A0pdev =3D platform_device_register_simple("gpio-mdio=
=2Dbitbang", 0, NULL, 0);
> +
> +=A0=A0=A0=A0=A0=A0=A0return 0;
> +}
> +late_initcall(hack_init);
Why do you need this? The name already suggests that you are aware that this
should be autoprobed, but it would be good to have a comment explaining
why you did it this way.
Arnd <><
next prev parent reply other threads:[~2007-04-16 23:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-16 6:26 [PATCH] [1/5] pasemi: allow 8KB config space for I/O bridge Olof Johansson
2007-04-16 6:27 ` [PATCH] [2/5] pasemi: enable one more hid bit Olof Johansson
2007-04-24 0:27 ` Benjamin Herrenschmidt
2007-04-24 1:04 ` Olof Johansson
2007-04-16 6:28 ` [PATCH] [3/5] pasemi: reset mpic on boot Olof Johansson
2007-04-16 6:30 ` [PATCH] [4/5] pasemi: PA6T oprofile support Olof Johansson
2007-04-18 6:38 ` [PATCH] [4/5] [v2] " Olof Johansson
2007-04-16 6:31 ` [PATCH] [5/5] pasemi: GPIO MDIO of_platform driver Olof Johansson
2007-04-16 23:07 ` Arnd Bergmann [this message]
2007-04-17 0:47 ` Olof Johansson
2007-04-18 6:39 ` [PATCH] [5/5] [v2] " Olof Johansson
2007-05-01 4:35 ` Paul Mackerras
2007-05-01 4:45 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704170107.12709.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.