From: Jarek Poplawski <jarkao2@o2.pl>
To: "Yuriy N\. Shkandybin" <jura@netams.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Paul Mackerras <paulus@samba.org>,
netdev@vger.kernel.org, Michal Ostrowski <mostrows@speakeasy.net>
Subject: Re: + ppp_generic-fix-lockdep-warning.patch added to -mm tree
Date: Tue, 17 Apr 2007 09:37:44 +0200 [thread overview]
Message-ID: <20070417073744.GA1976@ff.dom.local> (raw)
In-Reply-To: <028701c77c16$bcd68a90$0202fea9@Jura>
On Wed, Apr 11, 2007 at 12:52:28PM +0400, Yuriy N. Shkandybin wrote:
...
> >On Wed, 11 Apr 2007 09:57:33 +0400 "Yuriy N. Shkandybin" <jura@netams.com>
> >wrote:
> >
> >>I've tested 2.6.21-rc6-mm1
> >>Linux vpn1 2.6.21-rc6-mm1 #4 SMP Wed Apr 11 03:34:26 MSD 2007 x86_64
> >>Intel(R) Pentium(R) D CPU 2.80GHz GenuineIntel GNU/Linux
> >>
> >>warn appeares upon first pppoe connection to rp-pppoe server in kernel
> >>mode
> >>
> >
> >Thanks. So you're saying that
> >ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc6/2.6.21-rc6-mm1/broken-out/ppp_generic-fix-lockdep-warning.patch
> >did not fix anything?
> As i understand this patch already in -mm tree, so I've booted into last mm
> kernel and received this locked warning.
> Or i've mistaked and should apply this patch manually?
Hi!
Yuriy - thanks for testing my patch ...(pause) Not!
It seems this patch is not visible in this version - probably
is overpatched by something else. But your new log shows there
is another connection between these locks (ppp_xmit_process
and ppp_push instead of ppp_channel_push in "-> #0"), so the
patch is not sufficient (and could be dumped).
I don't know your vlans configuration, but it seems the real
lockup isn't very probable here - it's rather lockdep question.
I think vlan's too broad lockdep class is the main "guilty"
here, but probably pppoe also could be enhanced: it's making
the things unnecessarily complicated by calling dev_queue_xmit
under ppp_generic's xmit locks. I wonder if there is any reason
against using a tasklet here.
I'll try to find more time to untie this yet - or maybe some
maintainer will find this interesting, too...
Regards,
Jarek P.
PS: sorry for late responding (vacations).
next prev parent reply other threads:[~2007-04-17 7:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-28 23:53 + ppp_generic-fix-lockdep-warning.patch added to -mm tree akpm
[not found] ` <01ef01c77bfe$4cdfe640$0202fea9@Jura>
2007-04-11 7:09 ` Andrew Morton
2007-04-11 8:52 ` Yuriy N. Shkandybin
2007-04-11 8:58 ` Andrew Morton
2007-04-17 7:37 ` Jarek Poplawski [this message]
2007-04-17 13:26 ` Michal Ostrowski
2007-04-18 6:40 ` Jarek Poplawski
2007-04-19 5:30 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070417073744.GA1976@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=akpm@linux-foundation.org \
--cc=jura@netams.com \
--cc=mostrows@speakeasy.net \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.