From: Dave Jones <davej@redhat.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: luming.yu@intel.com, adaplas@pol.net, greg@kroah.com,
len.brown@intel.com
Subject: drivers/video/output.c
Date: Tue, 17 Apr 2007 17:37:16 -0400 [thread overview]
Message-ID: <20070417213716.GB7284@redhat.com> (raw)
commit 2dec3ba8d872aa3ffbcdb8f6f8a2c0bcd44e9910 puzzles me.
git-bisect just fingered it as responsible for my "backlight doesn't turn on"
suspend/resume regression on the Thinkpad X60. I think it's lying.
Why? Because afaict, drivers/video/output.c is never compiled.
That commit adds the driver, but doesn't touch any Makefile, and I
don't see anything obvious in the follow-in commits that would 'enable' it.
Asides from git-bisect failing me again[1], what gives with this file?
Dave
[1] bisecting suspend regressions _really_ sucks. Each time I've tried this
I've found 2-3 different ways we regressed along the bisection, making it
hard to say "good" or "bad" when the answer is "bad, but broken differently"
--
http://www.codemonkey.org.uk
next reply other threads:[~2007-04-17 21:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 21:37 Dave Jones [this message]
2007-04-17 23:43 ` drivers/video/output.c Antonino A. Daplas
2007-04-18 3:38 ` drivers/video/output.c Brown, Len
2007-04-25 14:17 ` drivers/video/output.c Luming Yu
2007-04-18 7:10 ` drivers/video/output.c Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070417213716.GB7284@redhat.com \
--to=davej@redhat.com \
--cc=adaplas@pol.net \
--cc=greg@kroah.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luming.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.