From: David Gibson <david@gibson.dropbear.id.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: Fix breakage caused by tlb flush batch changes
Date: Wed, 18 Apr 2007 18:04:16 +1000 [thread overview]
Message-ID: <20070418080416.GA31443@localhost.localdomain> (raw)
In-Reply-To: <1176881992.7639.2.camel@localhost.localdomain>
On Wed, Apr 18, 2007 at 05:39:52PM +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2007-04-18 at 16:19 +1000, David Gibson wrote:
> > BenH's commit a741e67969577163a4cfc78d7fd2753219087ef1 in powerpc.git,
> > although (AFAICT) only intended to affect ppc64, also has side-effects
> > which break 44x. I think 40x, 8xx and Freescale Book E are also
> > affected, though I haven't tested them.
> >
> > The problem lies in unconditionally removing flush_tlb_pending() from
> > the versions of flush_tlb_mm(), flush_tlb_range() and
> > flush_tlb_kernel_range() used on ppc64 - which are also used the
> > embedded platforms mentioned above.
> >
> > The patch below restores the necessary flushes and fixes the breakage
> > for 44x. They should also fix any breakage for the other platforms,
> > but again I haven't tested those.
>
> Damn, do these things use a batch at all ? If not, they should defkine
> the whole set a functions separately rather than ifdef's like that...
> flush_tlb_pending is a bad name for that.
No they don't and yes they should. I was planning to do such a
redefinition along with other cleanups related to splitting the MMU
related .h files up by CPU/MMU family.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
prev parent reply other threads:[~2007-04-18 8:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-18 6:19 Fix breakage caused by tlb flush batch changes David Gibson
2007-04-18 7:39 ` Benjamin Herrenschmidt
2007-04-18 8:04 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070418080416.GA31443@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.