From: Ralf Baechle <ralf@linux-mips.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Retry {save,restore}_fp_context if failed in atomic context.
Date: Wed, 18 Apr 2007 12:30:46 +0100 [thread overview]
Message-ID: <20070418113046.GC3938@linux-mips.org> (raw)
In-Reply-To: <20070416.233235.75185596.anemo@mba.ocn.ne.jp>
On Mon, Apr 16, 2007 at 11:32:35PM +0900, Atsushi Nemoto wrote:
> > The save_fp_context()/restore_fp_context() might sleep on accessing
> > user stack and therefore might lose FPU ownership in middle of them.
> >
> > If these function failed due to "in_atomic" test in do_page_fault,
> > touch the sigcontext area in non-atomic context and retry these
> > save/restore operation.
> >
> > This is a replacement of a (broken) fix which was titled "Allow CpU
> > exception in kernel partially".
> >
> > Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
>
> And this is for 2.6.20-stable.
Both applied, also to older -stable branches except 2.6.16. In case of
2.6.16 it would have been more time consuming than justifyable and since
the bug this patch fixes is comparable to what we had before starting the
whole surgery I have no problem to leave 2.6.16 as it is. Anybody still
using 2.6.16 should upgrade anyway ...
Ralf
next prev parent reply other threads:[~2007-04-18 11:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-16 14:19 [PATCH] Retry {save,restore}_fp_context if failed in atomic context Atsushi Nemoto
2007-04-16 14:32 ` Atsushi Nemoto
2007-04-18 11:30 ` Ralf Baechle [this message]
2007-04-18 14:13 ` Atsushi Nemoto
2007-04-18 16:40 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070418113046.GC3938@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.