All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: discuss@x86-64.org
Cc: linux-kernel@vger.kernel.org, Arjan van de Ven <arjan@linux.intel.com>
Subject: Dropping CONFIG_REORDER on x86-64 for 2.6.22
Date: Thu, 19 Apr 2007 13:54:52 +0200	[thread overview]
Message-ID: <200704191354.52985.ak@suse.de> (raw)


Hallo,

I'm thinking about dropping the x86-64 CONFIG_REORDER for 2.6.22. 
The function enabled -ffunction-sections and then tries to reorder
the executable

While that's in theory a worthy goal to save TLB/icache, in practice it 
didn't really work out.

Rationale:
- It cannot be enabled in normal builds because all current lds
become very slow when they have to handle thousands of sections.

- The list of hot functions it needs - arch/x86_64/kernel/functionlist -
hasn't been changed for a long time and is already out of date. 
I also don't know no sane way to keep it uptodate. Profile feedback
at runtime is not practical for the kernel and even if it's questionable
we would find a good training workload. Trying to change the manually
is imho foolish and likely not too useful anyways (if any hot function
is missed the TLB savings will be lost and it is unlikely we can
get 100% coverage) 

- The workloads of the kernel are too diverse to make this concept
really work

So I'm planning to drop the option and arch/x86_64/kernel/functionlist

Comments?

-Andi


             reply	other threads:[~2007-04-19 11:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-19 11:54 Andi Kleen [this message]
2007-04-19 14:27 ` Dropping CONFIG_REORDER on x86-64 for 2.6.22 Arjan van de Ven
2007-04-19 16:59   ` Chuck Ebbert
2007-04-20  8:35   ` Måns Rullgård
2007-04-20  9:37     ` [discuss] " Andi Kleen
2007-04-20 17:24       ` Måns Rullgård
2007-04-19 17:06 ` Adrian Bunk
2007-04-19 20:10 ` David Miller
2007-04-20  1:21   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704191354.52985.ak@suse.de \
    --to=ak@suse.de \
    --cc=arjan@linux.intel.com \
    --cc=discuss@x86-64.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.