From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754331AbXDSXv1 (ORCPT ); Thu, 19 Apr 2007 19:51:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754333AbXDSXv1 (ORCPT ); Thu, 19 Apr 2007 19:51:27 -0400 Received: from smtp1.linux-foundation.org ([65.172.181.25]:55899 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754326AbXDSXv0 (ORCPT ); Thu, 19 Apr 2007 19:51:26 -0400 Date: Thu, 19 Apr 2007 16:51:03 -0700 From: Andrew Morton To: "Eric W. Biederman" Cc: , Oleg Nesterov , Christoph Hellwig , , Jes Sorensen , Tony Luck Subject: Re: [PATCH] ia64 sn xpc: Convert to use kthread API. Message-Id: <20070419165103.5b671b28.akpm@linux-foundation.org> In-Reply-To: <1176969574439-git-send-email-ebiederm@xmission.com> References: <1176969574439-git-send-email-ebiederm@xmission.com> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Apr 2007 01:58:44 -0600 "Eric W. Biederman" wrote: > > This patch starts the xpc kernel threads using kthread_run > not a combination of kernel_thread and daemonize. Resuling > in slightly simpler and more maintainable code. > > Cc: Jes Sorensen > Cc: Tony Luck > Signed-off-by: Eric W. Biederman > --- > arch/ia64/sn/kernel/xpc_main.c | 31 +++++++++++++------------------ Another driver which should be fully converted to the kthread API: kthread_stop() and kthread_should_stop(). And according to my logs, this driver was added to the tree more than a year _after_ the kthread interface was made available. This isn't good.