From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Mackall Subject: Re: [patch 20/20] Add apply_to_page_range() which applies a function to a pte range. Date: Thu, 19 Apr 2007 14:59:57 -0500 Message-ID: <20070419195957.GF11115@waste.org> References: <20070404191151.009821039@goop.org> <20070404191206.675793431@goop.org> <20070405044133.GE4892@waste.org> <46149CC9.2070903@goop.org> <20070417205652.GM11115@waste.org> <4627C6B9.7000605@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4627C6B9.7000605@goop.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Jeremy Fitzhardinge Cc: Matt Mackall , Ian Pratt , lkml , Chris Wright , virtualization@lists.osdl.org, Andrew Morton , Christoph Lameter , Ingo Molnar List-Id: virtualization@lists.linuxfoundation.org On Thu, Apr 19, 2007 at 12:44:57PM -0700, Jeremy Fitzhardinge wrote: > Matt Mackall wrote: > > I think adding a flags field and an allocate flag to my callback > > struct would be sufficient here. > > > > Yes, probably. > > What about something that wants to shatter superpages? Haven't thought a huge amount about that. Perhaps it's best done with the level 3 callback? > Don't know that that's a huge concern. The typedef namespace (*_t) is > pretty empty, and its not like we're talking about something that's > visible outside the kernel. And the syntax is *really* ugly. Don't really care about this much. -- Mathematics is the supreme nostalgia of our time. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1767014AbXDSUNQ (ORCPT ); Thu, 19 Apr 2007 16:13:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1767018AbXDSUNQ (ORCPT ); Thu, 19 Apr 2007 16:13:16 -0400 Received: from waste.org ([66.93.16.53]:39384 "EHLO waste.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1767014AbXDSUNP (ORCPT ); Thu, 19 Apr 2007 16:13:15 -0400 Date: Thu, 19 Apr 2007 14:59:57 -0500 From: Matt Mackall To: Jeremy Fitzhardinge Cc: Andi Kleen , Andrew Morton , virtualization@lists.osdl.org, lkml , Ian Pratt , Christian Limpach , Chris Wright , Christoph Lameter , Matt Mackall , Ingo Molnar Subject: Re: [patch 20/20] Add apply_to_page_range() which applies a function to a pte range. Message-ID: <20070419195957.GF11115@waste.org> References: <20070404191151.009821039@goop.org> <20070404191206.675793431@goop.org> <20070405044133.GE4892@waste.org> <46149CC9.2070903@goop.org> <20070417205652.GM11115@waste.org> <4627C6B9.7000605@goop.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4627C6B9.7000605@goop.org> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 19, 2007 at 12:44:57PM -0700, Jeremy Fitzhardinge wrote: > Matt Mackall wrote: > > I think adding a flags field and an allocate flag to my callback > > struct would be sufficient here. > > > > Yes, probably. > > What about something that wants to shatter superpages? Haven't thought a huge amount about that. Perhaps it's best done with the level 3 callback? > Don't know that that's a huge concern. The typedef namespace (*_t) is > pretty empty, and its not like we're talking about something that's > visible outside the kernel. And the syntax is *really* ugly. Don't really care about this much. -- Mathematics is the supreme nostalgia of our time.