From: Jarek Poplawski <jarkao2@o2.pl>
To: David Chinner <dgc@sgi.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH -mm] workqueue: debug possible endless loop in cancel_rearming_delayed_work
Date: Fri, 20 Apr 2007 12:21:57 +0200 [thread overview]
Message-ID: <20070420102157.GD1695@ff.dom.local> (raw)
In-Reply-To: <20070420085354.GP32602149@melbourne.sgi.com>
On Fri, Apr 20, 2007 at 06:53:54PM +1000, David Chinner wrote:
...
> Yes, after spending another two hours working out why my fix was
> then hanging in cancel_rearming_delayed_work() I was a little bit
> annoyed at the now obviously misleading comment. Five minutes later
I agree with your feelings, but strictly speaking it's not "obviously
misleading":
" * cancel_rearming_delayed_work - reliably kill off a delayed
keventd work whose handler rearms the delayed work."
And all your rearmed works were, probably, reliably killed!
> I'd fixed the bug properly. A better comment would have saved me two
> hours of wasted time.....
It seems to be an Achilles' heel of linux...
Regards,
Jarek P.
next prev parent reply other threads:[~2007-04-20 10:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-19 6:54 [PATCH -mm] workqueue: debug possible endless loop in cancel_rearming_delayed_work Jarek Poplawski
2007-04-19 7:32 ` Ingo Molnar
2007-04-19 8:28 ` Jarek Poplawski
2007-04-19 14:48 ` David Chinner
2007-04-19 14:46 ` David Chinner
2007-04-20 8:13 ` Jarek Poplawski
2007-04-20 8:53 ` David Chinner
2007-04-20 10:21 ` Jarek Poplawski [this message]
2007-04-20 11:01 ` David Chinner
2007-04-20 12:12 ` [PATCH] workqueue: cancel_rearming_delayed_work/workqueue usage warning Jarek Poplawski
2007-04-20 17:23 ` Oleg Nesterov
2007-04-23 9:41 ` Jarek Poplawski
2007-04-19 17:07 ` [PATCH -mm] workqueue: debug possible endless loop in cancel_rearming_delayed_work Chuck Ebbert
2007-04-20 7:14 ` Jarek Poplawski
-- strict thread matches above, loose matches on Subject: below --
2007-04-20 11:09 Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070420102157.GD1695@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=dgc@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.