All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: "Langsdorf, Mark" <mark.langsdorf@amd.com>
Cc: cpufreq@lists.linux.org.uk
Subject: Re: Voltage tweaking in powernow_k8
Date: Fri, 20 Apr 2007 14:55:33 -0400	[thread overview]
Message-ID: <20070420185533.GE13939@redhat.com> (raw)
In-Reply-To: <1449F58C868D8D4E9C72945771150BDF02076D28@SAUSEXMB1.amd.com>

On Fri, Apr 20, 2007 at 01:35:23PM -0500, Langsdorf, Mark wrote:

 > > It may be a good idea to print warnings when the parameter is used,
 > > to clearly state the unsupported and potentally dangerous effect of
 > > the parameter (though it would not be enough to change your view,
 > > I guess...).
 > 
 > I still wouldn't be able to support it, no.  That's out of my
 > hands.

I'm not enthusiastic about merging this code at all.
The big problem I see is that a lot of the reasons people want
to do this is "The bios say xyz, but the datasheet says it can do xyz+-1"
In many cases, the bios *really* does know best.  Board layout differences,
differences in quality of VRMs etc between vendors may mean that yes, you
can get away with tweaking things on one board, but someone else with
the "same" board may notice stability problems.
The kind of bugs that manifest with incorrectly configured frequency scaling
are nigh on impossible to track down, and as someone who sits on the
recieving end of user bugreports, I don't want to have to deal with that,
and I can't imagine other distributors would feel differently.

	Dave

-- 
http://www.codemonkey.org.uk

  reply	other threads:[~2007-04-20 18:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-15 17:18 Voltage tweaking in powernow_k8 Roberto Gordo Saez
2007-04-16 13:55 ` Langsdorf, Mark
2007-04-16 15:25   ` Roberto Gordo Saez
2007-04-20 18:35     ` Langsdorf, Mark
2007-04-20 18:55       ` Dave Jones [this message]
2007-04-20 21:03         ` Roberto Gordo Saez
2007-04-20 21:57           ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070420185533.GE13939@redhat.com \
    --to=davej@redhat.com \
    --cc=cpufreq@lists.linux.org.uk \
    --cc=mark.langsdorf@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.