From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HfFsp-0002kk-JO for mharc-grub-devel@gnu.org; Sat, 21 Apr 2007 09:44:11 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HfFsn-0002kb-JB for grub-devel@gnu.org; Sat, 21 Apr 2007 09:44:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HfFsk-0002kE-MC for grub-devel@gnu.org; Sat, 21 Apr 2007 09:44:08 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HfFsk-0002jx-Fb for grub-devel@gnu.org; Sat, 21 Apr 2007 09:44:06 -0400 Received: from [212.85.152.101] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HfFnZ-0006Zt-12 for grub-devel@gnu.org; Sat, 21 Apr 2007 09:38:45 -0400 Received: from kotoba.oasis.nexedi.com (kotoba.oasis.nexedi.com [212.85.152.101]) by kotoba.storever.com (Postfix) with ESMTP id 3C18D3D0CE670 for ; Sat, 21 Apr 2007 19:31:54 +0200 (CEST) Received: from [??1] (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id 171FA3D0CE66F for ; Sat, 21 Apr 2007 19:31:54 +0200 (CEST) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sat, 21 Apr 2007 15:38:38 +0200 User-Agent: KMail/1.8.2 References: <20061015101842.GC4265@khazad.dyndns.org> <20070411155040.GA6722@aragorn> <20070417124954.GA28437@aragorn> In-Reply-To: <20070417124954.GA28437@aragorn> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200704211538.38367.okuji@enbug.org> X-Bogosity: No, tests=bogofilter, spamicity=0.000018, version=0.17.2 X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) Subject: Re: update-grub2 patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Apr 2007 13:44:10 -0000 On Tuesday 17 April 2007 14:49, Robert Millan wrote: > Here's my patch. Let me know if it's ok for commit. To include this in the official repository, you need to take care about the portability. You should not rely on the existence of some programs. For instance, you use bash. This is not good. Use /bin/sh instead. You use shopt. This is not good, because this is specific to bash. The way in which you write test expressions is not very portable. Also, don't use negations (i.e. `!'), because they don't behave correctly on some platforms. Use "if ... then else ..." instead. For more information, please look at the chapter "Portable Shell Programming" in the Autoconf manual. Regards, Okuji