From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030608AbXDVMfH (ORCPT ); Sun, 22 Apr 2007 08:35:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030512AbXDVMfG (ORCPT ); Sun, 22 Apr 2007 08:35:06 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:46967 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030608AbXDVMfF (ORCPT ); Sun, 22 Apr 2007 08:35:05 -0400 Date: Sun, 22 Apr 2007 13:34:56 +0100 From: Christoph Hellwig To: "Eric W. Biederman" Cc: ", containers@lists.osdl.org, Oleg Nesterov , Christoph Hellwig , linux-kernel@vger.kernel.org, Paul Mackerras Subject: Re: [PATCH] powerpc pseries rtasd: Convert to kthread API. Message-ID: <20070422123456.GG20763@infradead.org> Mail-Followup-To: Christoph Hellwig , "Eric W. Biederman" , ", containers@lists.osdl.org, Oleg Nesterov , linux-kernel@vger.kernel.org, Paul Mackerras References: <1176969582987-git-send-email-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1176969582987-git-send-email-ebiederm@xmission.com> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 19, 2007 at 01:58:46AM -0600, Eric W. Biederman wrote: > From: Eric W. Biederman > > This patch modifies the startup of rtasd to use kthread_run instaed of > a combination of kernel_thread and daemonize. Making the code a little > simpler and more maintainble. Looks okay, but I have some questions about the original code. Why does the driver only check if it really needs to run in the thread and calls vmalloc from it? If we did all these in the initialization function we could actually properly unwind.